Closed Bug 390921 Opened 17 years ago Closed 17 years ago

mail back/forward menu item formatting is weird (folder - subject:author)

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3

People

(Reporter: tuukka.tolvanen, Assigned: tuukka.tolvanen)

References

Details

Attachments

(2 files, 1 obsolete file)

tbird trunk 2007-08-02-15Z mail back/forward toolbar button dropdown menu item formatting mashes together the last word of subject and the first of author such that it looks a bit weird to me: example (current folder and another folder cases): Hello World:Bob Author Inbox - Hello World:Bob Author expected something more like: Hello World - Bob Author Inbox - Hello World - Bob Author http://mxr.mozilla.org/mozilla/source/mail/base/content/mailWindowOverlay.js#742
Attached patch patch1 (obsolete) (deleted) — Splinter Review
fixes another minor issue too -- I noticed a draft without subject showed up as "null", so this omits it and the separator in that case
Assignee: nobody → tuukka.tolvanen
Status: NEW → ASSIGNED
Attachment #275246 - Flags: superreview?
Attachment #275246 - Flags: review?(bienvenu)
Attached image before/after (deleted) —
Attachment #275246 - Flags: superreview? → superreview?(mscott)
Comment on attachment 275246 [details] [diff] [review] patch1 thx, looks good.
Attachment #275246 - Flags: review?(bienvenu) → review+
The subjects are also missing "Re:" in case they are replies (similar to bug 363996), just in case you wanna take care of that too while you're at it;)
Attached patch patch2 incl Re:construction (deleted) — Splinter Review
makes sense ...thanks for the bug pointer
Attachment #275246 - Attachment is obsolete: true
Attachment #275272 - Flags: superreview?(mscott)
Attachment #275272 - Flags: review?(bienvenu)
Attachment #275246 - Flags: superreview?(mscott)
Comment on attachment 275272 [details] [diff] [review] patch2 incl Re:construction thx, good idea.
Attachment #275272 - Flags: review?(bienvenu) → review+
Attachment #275272 - Flags: superreview?(mscott) → superreview+
Whiteboard: [checkin needed]
Keywords: checkin-needed
Whiteboard: [checkin needed]
mail/base/content/mailWindowOverlay.js 1.177
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3
Blocks: TB2SM
No longer blocks: TB2SM
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: