Closed Bug 391006 Opened 17 years ago Closed 15 years ago

"Open Message for ID" should be removed from Message-IDs' context menu when it's the same message you're viewing

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.1a1

People

(Reporter: steffen.wilberg, Assigned: mkmelin)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 62033 added Message-IDs to news and email. It's disabled by default. To enable it for both email and news, set the hidden pref mailnews.headers.showMessageId to true and restart Thunderbird. The context menu for email Message-IDs displays "Open Message for ID", which tries to open the very same message. In other words, nothing happens. And I wouldn't expect anything to happen since the message is already displayed. So this should just be removed.
The same applies to the link for the Message-ID, but I guess that is necessary to be able to display the context menu.
Call your attention to this comment in Bug #62033 https://bugzilla.mozilla.org/show_bug.cgi?id=62033#c40 "References are now shown for news messages and could be activated for mail messages too by pref." The news pref is coded into the patch without a pref toggle, while mail dos get a pref toggle ability.
Sure, but this bug is not about References, but about Message-IDs. Unlike References, Message-IDs are disabled for both mail and news - it doesn't matter though whether it's enabled by default or not though. The bug is: Message-IDs have a useless context menu entry "Open Message for ID", which should be removed.
OS: Windows Vista → All
Hardware: PC → All
If I'm reading this correctly, the "Open Message for ID" is a recursive item that opens the message id of the current message. If that's correct, options like that are pretty useless and should be removed.
If the message reader pane is only showing the ID of the current message then it is not working correctly. It should be displaying all ID's of the thread the current message part of. The utility of having the message ID strings from the message header is clickability to jump to another point in a thread. Also there was ability in NC4 to use message ID's to link content into a new message being posted to the same NNTP server for the news case. I will point out that bug #62033 was a mail/news core fix for SM that brought the feature to Tb also. It's off by default for mail, and on for news. For mail this feature would likely have more utility with IMAP since it's message store is more like NNTP.
Ronald, you're probably referring to References, which can be shown by setting mailnews.headers.showReferences to true. However, that's broken in Thunderbird's new message header...
(In reply to comment #6) > Ronald, you're probably referring to References, which can be shown by setting > mailnews.headers.showReferences to true. However, that's broken in > Thunderbird's new message header... Correct and if all the references are not listed it would not be possible to pick one and then use the "Open Message for ID" context menu item.
Attached image screenshot (deleted) —
This is the menu item this bug is about: message-id 1 context menu -> Open Message for ID It just opens the current message in the same place.
Summary: "Open Message for ID" should be removed from Message-IDs' context menu → "Open Message for ID" should be removed from Message-IDs' context menu when it's the same message you're viewing
Attached patch proposed fix (deleted) — Splinter Review
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #410849 - Flags: review?(philringnalda)
Attachment #410849 - Flags: ui-review?(clarkbw)
Oh, that should preferably be gFolderDisplay.selectedMessage instead
Comment on attachment 410849 [details] [diff] [review] proposed fix looks ok
Attachment #410849 - Flags: ui-review?(clarkbw) → ui-review+
Comment on attachment 410849 [details] [diff] [review] proposed fix Sorry for the delay, r=me with your own review comment addressed :)
Attachment #410849 - Flags: review?(philringnalda) → review+
changeset: 4592:b03885613306 http://hg.mozilla.org/comm-central/rev/b03885613306 ->FIXED
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1a1
Blocks: TB2SM
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: