Closed
Bug 39270
Opened 25 years ago
Closed 24 years ago
NS_IMPL_QUERY_INTERFACE is deprecated
Categories
(Core :: XUL, defect, P3)
Tracking
()
VERIFIED
FIXED
M18
People
(Reporter: Joerg.Brunsmann, Assigned: mcafee)
Details
as you can see in
http://lxr.mozilla.org/mozilla/source/xpcom/base/nsISupportsUtils.h#495
the macro NS_IMPL_QUERY_INTERFACE is deprecated.
The new macro-based QI allows to switch to a
table driven solution.
The following patch switches to NS_IMPL_ISUPPORTS1
Index: xpfe/appshell/src/nsCommonDialogs.cpp
===================================================================
RCS file: /cvsroot/mozilla/xpfe/appshell/src/nsCommonDialogs.cpp,v
retrieving revision 1.27
diff -r1.27 nsCommonDialogs.cpp
494,496c494,495
< NS_IMPL_ADDREF(nsCommonDialogs);
< NS_IMPL_RELEASE(nsCommonDialogs);
< NS_IMPL_QUERY_INTERFACE(nsCommonDialogs, NS_GET_IID(nsICommonDialogs));
---
> NS_IMPL_ISUPPORTS1(nsCommonDialogs, nsICommonDialogs)
>
|
||
Comment 1•25 years ago
|
||
reassigning to don, do you guys own this?
Assignee: trudelle → don
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
Assignee | |
Comment 2•24 years ago
|
||
patch, mcafee, m18
|
|
Assignee | |
Comment 3•24 years ago
|
||
fixed.
QA: code-level change, no verification is necessary.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•