Closed Bug 39529 Opened 25 years ago Closed 24 years ago

The text editor caret is too "thick"

Categories

(Core :: DOM: Editor, defect, P3)

x86
Windows NT
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: locka, Assigned: anthonyd)

References

Details

(Keywords: polish, Whiteboard: [nsbeta3+] fix checked in)

Launch Mozilla and click on the address bar to give it keyboard focus. The editor caret is two pixels thick when in Windows it is conventional for it to be just one pixel. The extra pixel usually means the caret touches the edge of a character before it giving it an unpleasant XOR effect.
-> Editor
Assignee: trudelle → beppe
Component: XP Toolkit/Widgets → Editor
QA Contact: jrgm → sujay
assigning to Simon
Assignee: beppe → sfraser
Target Milestone: --- → M17
You can change this in nsLookAndFeel. I am reliably informed that windows carets are usually two pixels thick, which is what I did. It's also the same thickness as the carets in 4.x composer, and MSDev. Wordpad seems to eb the odd man out, having a narrower one.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → WONTFIX
verified in 5/17 build.
Status: RESOLVED → VERIFIED
I agree that many editors seem to use 2 pixel carets but I was commenting on the address bar which is a simple text entry widget. Windows, Linux and Mac predominantly use a single pixel caret for such fields. IE and 4.x on Windows use single pixel carets for everything except the HTML editors (don't ask me why).
Status: VERIFIED → REOPENED
Resolution: WONTFIX → ---
Good point. I'll do something about this.
Status: REOPENED → ASSIGNED
Target Milestone: M17 → M18
setting polish keyword and reassign to anthonyd
Assignee: sfraser → anthonyd
Status: ASSIGNED → NEW
Keywords: polish
Status: NEW → ASSIGNED
I just wanted to be clear on this bug before I start making changes. This is Windows only, AND the caret needs to be 1 pixel wide for the URL Location bar, and in all other places leave it the same (at 2 pixels wide). Is this correct? Anthony
This is bug is basically fixed in my tree. I made changes to nsLookAndFeel to represent the 2 different caret widths, but the problem that now exists is getting a nsLookAndFeel from nsTextEditorFocusListener, which only has a nsIEditor pointer. THe way it works is you need a preshell to get the prescontext to get the nsLookandFeel, and nsIEdtior doesnt know about the preShell. Dave Hyatt said the best solution would be to seperate nsLookAndFeel from presCOntext, and make it stand alone. Still trying to decide what the best solution is. Anthony
Whiteboard: fix in hand
created new bug (to add service provider for nsLookandFeel) that this bug depends on. added beppe to cc list. Anthony
Depends on: 46445
Keywords: nsbeta3
Whiteboard: fix in hand → nsbeta3+
setting to nsbeta3+
Whiteboard: nsbeta3+ → nsbeta3+, fix in hand
adding the brackets in the status
Whiteboard: nsbeta3+, fix in hand → [nsbeta3+] fix in hand
Status: ASSIGNED → RESOLVED
Closed: 25 years ago24 years ago
Resolution: --- → FIXED
Whiteboard: [nsbeta3+] fix in hand → [nsbeta3+] fix checked in
checked in today
tony, you're my new hero!
verified in 8/9 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.