Closed Bug 39823 Opened 25 years ago Closed 23 years ago

Sane sample plugin should use NSGetModule instead of NSGetFactory

Categories

(Core Graveyard :: Plug-ins, defect, P3)

Product:
Core Graveyard
Component:
Plug-ins
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED WONTFIX
Milestone:
Future

People

(Reporter: beard, Assigned: serhunt)

References

Details

(Keywords: topembed)

Plugins aren't first class components, but they should not have a different entry point from components; they should implement NSGetModule so that they can register session-level factories.
Agree NSGetModule should be used for new plugins, but does that mean you'd remove support for NSGetFactory, et al? Wouldn't that blow away support for legacy plugins. Or is this just a documentation note? Or a bug filed against the sample plugin?
What legacy plugins?
Flash and Real for starters. Are we talking about the same thing?
OK - I'm way off base - I can't keep the 2 API's straight anymore. Sorry for my waste of bandwidth.
AFAIK, there are no released plugins using the new plugin APIs yet.
Ignore anything I wrote here. Blow away the NSGetFactory plugin stuff. I've got a huge block of code commented out in my plugin (the whole NSGetFactory, NSCanUnload, register, unregister). I hadn't touched it in months and thought it was something I migrated from my legacy plugin. Again, sorry I said anything.
Changing summary slightly. Surely this bug doesn't apply to plugins outside the Mozilla codebase. :-)
Summary: Plugins should use NSGetModule instead of NSGetFactory → Sample plugins should use NSGetModule instead of NSGetFactory
Depends on: 45460
Looks like waterson's changes to npsimple cleaned up that one in this regard. This remains an issue with the Sane plugin, so I'm going to narrow the scope of this bug. (It was probably too broad to begin with, anyway; if there are other sample plugins which exhibit this problem, please file separate bugs on them.) Rusty, I'm CC'ing you in case you want this one.
Summary: Sample plugins should use NSGetModule instead of NSGetFactory → Sane sample plugin should use NSGetModule instead of NSGetFactory
I would like this opportunity to allow Jothi (who is new Mozilla development) a chance to learn about plugin development and then get the rest of the team back up to speed.
Target Milestone: --- → Future
Not a Netscape 6 RTM blocker. FUTURE. This bug has been marked Future because the Netscape engineer it is assigned to is overburdened.
Blocks: 77151
cc:ing Mike Shaver from mozilla.org as I think he worked on NSGetModule/nsGetFactory. Our samples need to be correct.
*** Bug 45056 has been marked as a duplicate of this bug. ***
Keywords: topembed
There's not much point in this bug any longer, since we aren't pushing XPCOM plugins any longer.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WONTFIX
v
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.