Closed
Bug 39959
Opened 25 years ago
Closed 24 years ago
Patch to allow mac build with XSLT, SVG, MathML and Component Viewer
Categories
(SeaMonkey :: Build Config, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: peter.vanderbeken, Assigned: jj.enser)
Details
Attachments
(11 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
application/octet-stream
|
Details | |
(deleted),
application/octet-stream
|
Details | |
(deleted),
application/octet-stream
|
Details | |
(deleted),
application/octet-stream
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details |
This patch to the macintosh build system allows Mac users to easily build
Mozilla with XSLT, SVG or MathML enabled. I think it is important that we get
this in fairly quickly. These technologies do compile and run already in Mozilla
on the Mac but the steps required to enable them in the build are too many,
discouraging people to try them out. After this patch enabling one of these
should be as simple as editing one perl file. Moreover, adding other options
will be greatly simplified.
The effect on the regular builds is minimal (please correct me if i'm wrong), it
will just cause one nearly complete rebuild because of a change in a top header
(DefinesMozilla.h).
Reporter | ||
Comment 1•25 years ago
|
||
Reporter | ||
Comment 2•25 years ago
|
||
Reporter | ||
Comment 3•25 years ago
|
||
Reporter | ||
Comment 4•25 years ago
|
||
Reporter | ||
Comment 5•25 years ago
|
||
Reporter | ||
Comment 6•25 years ago
|
||
Reporter | ||
Comment 7•25 years ago
|
||
Confirming and adding sfraser@netscape.com and myself to the Cc list.
The intention of the patch of Peter is to make things very convenient, and
bring the Mac build process up-to-speed with what is done in other platforms.
Just like a single -enable-xxx, e.g., -enable-mathml allows MathML on Linux,
it will now be possible to just set $extensions{mathml} = 1 in the Perl script,
et voila... MathML is on the Mac!
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 10•25 years ago
|
||
Adding myself to CC.
Reporter | ||
Comment 11•25 years ago
|
||
I'm adding my patch to build component viewer on Mac. So much cross-platform
goodies that work on Mac, and yet nobody tests/uses them because they don't get
built. :-(
Summary: Patch to allow mac build with XSLT, SVG and MathML → Patch to allow mac build with XSLT, SVG, MathML and Component Viewer
Reporter | ||
Comment 12•25 years ago
|
||
Reporter | ||
Comment 13•25 years ago
|
||
Reporter | ||
Comment 14•25 years ago
|
||
Reporter | ||
Comment 15•25 years ago
|
||
Assignee | ||
Comment 16•24 years ago
|
||
Will test the patches with debug/optimized and with the extensions{} switches
turned on/off before checking them in.
Status: NEW → ASSIGNED
Reporter | ||
Comment 17•24 years ago
|
||
The mac projects that i have attached will not be up to date with the tree
anymore. I didn't upload new ones everytime something changed in them (i think
we'd have about ten versions in this bug by now). I also kept my local version
of NGLayoutBuildList.pm up to date with the tree. Shall i mail these updated
files directly to you?
Assignee | ||
Comment 18•24 years ago
|
||
Peter: Yep, that would be a good idea and save me time for testing. Thanks.
Comment 19•24 years ago
|
||
JJ, what are the chances of getting these changes in the tree sooner rather than
later? Since this would make it easier for people to test out new code before
it gets turned on in the default build, it should make that less risky, since
it'll be easier to get people to help out with the testing. I'm hoping to get
LDAP code turned on in the builds soon, and this would be very useful to that
end.
Assignee | ||
Comment 20•24 years ago
|
||
Sorry for the delay. This is not a quick & easy task to test and approve these
patches. I've been working on it on and off, and I need to bring all these files
up-to-date due to the number of checkins that happened since the last delivery
(6/18)
It is now my #1 priority and I work on this full-time. I expect to have to
feedback by the end of the day.
Peter, the files you sent me via email don't have CVS information with them (CVS
folders), so it's hard to identify which revision they are based on.
Reporter | ||
Comment 21•24 years ago
|
||
I can send you up-to-date versions. This is why i'd like to get these changes
in, the build system keeps changing and it's getting hard to keep up with it.
How would you like to get the patches? Diffs? Or i could copy the necessary cvs
folders too?
Assignee | ||
Comment 22•24 years ago
|
||
I'm sorry again I didn't handle your previous files quicker. Let's try and do it
right this time : I have a fresh tree I pulled around 6:30pm on wednesday
specifically to test your changes. If you email me the same "limited" structure
(15 files in 8 directories if I counted right, no CVS dirs) in the next 7 hours
(while I sleep), I'll throw them in that tree when I get up, and from then on,
I'll be able to merge the diffs if any ever gets modified before i check them in,
which shouldn't take too long at this point.
Thanks!
By the way, I only intended to perform build tests (flags on/off optimized &
debug), but if you have a few functionnal tests to recommend, let me know!
Assignee | ||
Comment 23•24 years ago
|
||
I've implemented Peter's latest patches and after minor adjustments, got it to
build optimized with the options{} switches turned off.
The Mac I'm using is taking _forever_ (seriously, like 5 hours) to complete a
cycle...
I'll kick another build with the options{} on when this one finishes, after which
I'll check in the patches.
Stay tuned!
Comment 24•24 years ago
|
||
Can't we just let Peter check in? Does he have checkin access?
Assignee | ||
Comment 25•24 years ago
|
||
Peter checked in the last changes to layout.mcp. Marking fixed.
To enable the new options, modify BuildNGLayout{Debug}.pl as follows:
$options{transformiix} = 1;
$options{mathml} = 1;
$options{svg} = 1;
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
Updated•20 years ago
|
OS: Mac System 9.x
You need to log in
before you can comment on or make changes to this bug.
Description
•