Closed Bug 40102 Opened 25 years ago Closed 21 years ago

68K headers included when targeting PowerPC

Categories

(SeaMonkey :: Build Config, defect, P3)

PowerPC
All
defect

Tracking

(Not tracked)

RESOLVED WONTFIX
Future

People

(Reporter: gordon, Assigned: beard)

References

Details

Attachments

(1 file)

[Low-hanging fruit for someone frustrated by the build process.] A4Stuff.h and SetUpA4.h are included by the Mac XPCOM IDL compiler in mac_xpidl_panel.cpp. The functions exported by this header are no-ops on PowerPC Macs. Conditionalizing the inclusion of these headers and the use of their functions lets the IDL compiler build without any of CodeWarrior's 68K tools. WIth an additional fix to XP widgetry, the entire program can build without any of CodeWarrior's 68K tools.
Blocks: 40100
Over to beard
Assignee: endico → beard
moving from archtitecture product to browser
Component: XPCOM → Browser-General
Product: Architecture → Browser
QA Contact: nobody → cls
Version: unspecified → other
oops. i meant to move to build-config
Component: Browser-General → Build Config
Personally, I don't see any reason to remove 68K build tools from your CodeWarrior installation. What harm are they doing? I may choose to build some 68K code in the future. If you remove the tools, I can't do that. I strenuously objected to not installing A FULL CodeWarrior Pro5 installation when that decisions was made. That said, the patch looks fine, except for the conditional tests, we're really talking TARGET_CPU_68K not TARGET_RT_MAC_68881 (there's no floating point here). Although, the real need for A4Stuff.h comes when we're NOT using CFM, so the test should probably be: #if TARGET_CPU_68K && !TARGET_RT_MAC_CFM
Status: NEW → ASSIGNED
Target Milestone: --- → Future
I have a really tiny disk on my portable; tThe mozilla tree alone takes up most of the disk. I hate to carry around extra baggage in my development tools if I don't absolutely need them. I think we should check these patches in since they are valid and safe (with Patrick's suggestions taken into account). If we ever change the tools to require 68K pieces then we're in a different ballgame but until then I don't see why we need these extra files in our build system. I think we should get these changes checked in ASAP.
OS: other → Mac System 9.0
Mozilla CFM build is dead; should this bug go with it?
OS: All
CFM specific. Marking wontfix.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → WONTFIX
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: