Closed Bug 40325 Opened 25 years ago Closed 24 years ago

[fix in hand]subtracting dev2app in some cases

Categories

(Core :: Layout, defect, P3)

PowerPC
Mac System 9.x
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: erik, Assigned: pierre)

Details

(Whiteboard: [fix in hand][nsbeta2-][nsbeta3+])

Pierre, Mac GFX is subtracting dev2app in some cases in nsFontMetricsMac.cpp. I believe this is wrong, since dev2app is a factor, as you can see in other places, where we are multiplying it with something else. We need to look at all those subtractions carefully, and determine the right thing to do. Frank, is this possibly something for Gary Wade to work on?
These subtractions look fine to me. They mean "one pixel below" because the other values are already converted to twips. Maybe we should have written "(1*dev2app)" instead of "dev2app"? Closed as Invalid.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → INVALID
But why would we want to subtract one pixel from all of those values? For example, the x-height will be large for large fonts, and small for small fonts, but we always subtract one pixel. That doesn't make sense to me. The amount that we subtract does not depend on the font size. We always subtract exactly one pixel. But why?
For the strikeout, subscript and superscript, I think it was a question of aesthetics. For X-height, you are right, it's a bug. Reopening, marked nsbeta2 because it's low-level GFX stuff with a very easy fix.
Status: RESOLVED → REOPENED
Keywords: nsbeta2
Resolution: INVALID → ---
Target Milestone: --- → M16
Status: REOPENED → ASSIGNED
This is non-essential for nsbeta2. Please retry post beta.
Whiteboard: nsbeta2-
M16 has been out for a while now, these bugs target milestones need to be updated.
Adding nsbeta3 keyword
Keywords: nsbeta3
Whiteboard: nsbeta2- → [nsbeta2-]
Summary: subtracting dev2app in some cases → [fix in hand]subtracting dev2app in some cases
Target Milestone: M16 → M18
Whiteboard: [nsbeta2-] → [fix in hand][nsbeta2-]
Approving for nsbeta3
Whiteboard: [fix in hand][nsbeta2-] → [fix in hand][nsbeta2-][nsbeta3+]
Fix checked in nsFontMetricsMac.cpp. This is mostly a bug-level code. I'm not sure how QA can verify it.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago24 years ago
Resolution: --- → FIXED
Marking verified per last comments.
Status: RESOLVED → VERIFIED
OS: Mac System 9.x
You need to log in before you can comment on or make changes to this bug.