Closed Bug 40486 Opened 25 years ago Closed 24 years ago

Filter UI: Action section is missing descriptive text

Categories

(MailNews Core :: Filters, defect, P4)

Product:
MailNews Core
Component:
Filters
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.1

People

(Reporter: laurel, Assigned: gerv)

References

(
URL
)

Details

Attachments

(3 files)

Patch - 3 lines
(deleted), patch
Details | Diff | Splinter Review
Screenshot
(deleted), image/gif
Details
Patch v.2
(deleted), patch
Details | Diff | Splinter Review
Using may24 m16 commercial build refer to mail filter spec: http://gooey/client/5.0/specs/mail/filters/Filters.html The filter rules dialog's Action section needs to have descriptive text, current spec revision 4/19/00 shows it to be: "When messages match the above criteria perform the following action:"
QA Contact: lchiang → laurel
Status: NEW → ASSIGNED
Target Milestone: --- → M17
mass moving to M18 and adding nsbeta3 keyword
Keywords: nsbeta3
Target Milestone: M17 → M18
Whiteboard: [nsbeta3-]
Target Milestone: M18 → Future
Assignee: alecf → gayatrib
Status: ASSIGNED → NEW
reassigning my filter bugs to gayatrib..
Got a fix in my tree for this - taking.
Assignee: gayatrib → hwaara
Keywords: nsbeta3
Whiteboard: [nsbeta3-]
Target Milestone: Future → mozilla0.9.1
Priority: P3 → P4
hwaara - will this do? Could you review, please? Gerv
Assignee: hwaara → gervase.markham
Attached patch Patch - 3 lines (deleted) — — Splinter Review
Re-ccing hwaara. Hwaara - I attached a patch when you weren't looking ;-) Gerv
Attached image Screenshot (deleted) —
Thanks for fixing this. r=hwaara
Keywords: approval, patch
What Seth said. Just replace "criteria" with "conditions" and you're done.
It's nice to have an accessible URL for the spec at last. Silly me for looking at the bug instead of hunting it down ;-) Seriously, another patch coming right up. Gerv
Attached patch Patch v.2 (deleted) — — Splinter Review
sr=sspitzer note: you might not need to do orient="vertical". I think the titlebox should orient that way by default.
my r= persists. gerv, do you want me to check this in for you?
Sure. If you want to check out whether seth is correct and modify the patch accordingly, feel free :-) I'm currently in the wrong OS, and in the middle of some Distributed Systems revision ;-) Gerv
I checked - orient=vertical is necessary. The default for <titlebox> is horizontal. Checked in by hwaara. Marking fixed. Gerv
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
thanks for checking about the default for orientation before checking in. (perhaps it is box that is vertical by default?)
OK using may17 commercial trunk build
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: