It would be clearer if menu entries read 'Allow _this_ site to...', and 'Block _this_ site from...'. For example: 'Allow site to Display Images' - it is not clear that the site referred to is the current site. 'Allow _this_ site to set images' is a better description of what it does.

Patch is: chrome/locales/en-US/global/locale/tasksOverlay.dtd line 32: -<!ENTITY walletAllowCookiesCmd.label "Allow Site to Set Cookies"> +<!ENTITY walletAllowCookiesCmd.label "Allow this Site to Set Cookies"> line 34: -<!ENTITY walletBlockCookiesCmd.label "Block Site from Setting Cookies"> +<!ENTITY walletBlockCookiesCmd.label "Block this Site from Setting Cookies"> line 37: -<!ENTITY walletAllowImagesCmd.label "Allow Site to Display Images"> +<!ENTITY walletAllowImagesCmd.label "Allow this Site to Display Images"> line 39: -<!ENTITY walletBlockImagesCmd.label "Block Site from Displaying Images"> +<!ENTITY walletBlockImagesCmd.label "Block this Site from Displaying Images">

Oops, forgot the build number: 2000052508

not XPMenus. reassigning to morse who, i believe, is handling the image blocking stuff.

added patch kw. awaiting review and checkin. :-)

morse, is this what we want to do?

As module owner I have no objection to the proposed wording changes, although I saw nothing wrong with the original wording.

Yes but there might be a problem with the original wording for naive users. E.g: user notices on her favourite news site, she always gets annoying banner ads from a site called tripleclick.com. She remembers seeing something in one of the menus about blocking images. So, she clicks on 'Block site from sending images', intending to enter tripleclick.com as the site to be blocked. *Bang* all the images from the news site disappear... Changing the text to 'this site' makes it clear what the function really does.

OK, I understand better now what the confusion was. And, as module owner, I approve the change. Procedure now is to get approval from either waterson or bendan and then the patch can be checked it. So go for it. If you don't have checkin privileges, then just get the approval and then notify me and I'll do the checkin.

Changing fictional "M30" to reality

Unfortunately I don't have check in privs, and I wouldn't know how to get approval. You will have to either email me the details, point me in the right direction, or do the check in yourself.

OK, I checked the fix in. In the future the correct procedure to follow is: 1. Submit patch and have it reviewed by any other developer 2. Get approval of module owner 3. Get approval from either brendan@mozilla.org or waterson@mozilla.org 4. Ask someone with checkin privileges (e.g., the module owner) to check it in for you.

Thanks :-)

over to tever (or elig) to vrfy...

VERIFIED: Mozilla 0.9 all plats It now says "Block Images from this Server" Close enough to the corrected language for me. BTW, can someone put this in the right component?