Closed
Bug 40761
Opened 25 years ago
Closed 23 years ago
Make the filter UI accessible
Categories
(MailNews Core :: Filters, defect)
MailNews Core
Filters
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.0
People
(Reporter: laurel, Assigned: hwaara)
References
(Blocks 1 open bug)
Details
(Keywords: polish)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
hwaara
:
review+
hwaara
:
superreview+
asa
:
approval+
|
Details | Diff | Splinter Review |
refer to message filters ui spec:
http://gooey/client/5.0/specs/mail/filters/Filters.html
Mnenmonics have been added in the current revision of the filter ui spec.
Please implement -- Win32 for sure. What about linux? 4.x had mnemonics in
menus, but not in dialogs (at least I haven't found any). Mac not applicable.
QA Contact: lchiang → laurel
Summary: Filter UI: mnemonics → Filter UI: mnemonics
Comment 1•25 years ago
|
||
everything is cross-platform, even mneomimcs, I couldn't implement it on 'just
win32' if I tried :)
Status: NEW → ASSIGNED
Target Milestone: --- → M20
Comment 2•24 years ago
|
||
->gayatrib
Assignee: alecf → gayatrib
Status: ASSIGNED → NEW
Component: Mail Window Front End → Filters
Assignee | ||
Comment 5•24 years ago
|
||
Jglick, are all the mnemonics up to date?
http://www.mozilla.org/mailnews/specs/filters/
Yeah, mnemonics are all there except "New Folder" on Filter Runs. "N" seems to
be available for that.
Assignee | ||
Comment 7•24 years ago
|
||
Jglick, I talked to trudelle. Were you aware that accesskey support is not
implemented for XUL, but only for HTML?
Are you even able to trigger an accesskey?
Seems like all our "support" for accesskeys in Mailnews is totally bogus!
Assignee | ||
Comment 9•24 years ago
|
||
jglick: that (implemention of accesskeys for XUL) is bug 959 if you are interested.
Assignee | ||
Comment 11•23 years ago
|
||
triaging
Severity: normal → minor
Priority: P3 → P4
Target Milestone: --- → Future
Assignee | ||
Updated•23 years ago
|
Priority: P4 → P3
Assignee | ||
Updated•23 years ago
|
Priority: P3 → --
Target Milestone: Future → mozilla1.0.1
Assignee | ||
Comment 12•23 years ago
|
||
Ssu, wanna take this too? :-)
Comment 13•23 years ago
|
||
hwaawa, did trudelle mention which bug would fix access keys in xul? I'm
gessing it might be the infamous bug 959.
Assignee | ||
Comment 14•23 years ago
|
||
Yes, that's the one. Poke jag so he will make a new patch and check it in. :-)
Depends on: Accesskey-XUL
Assignee | ||
Comment 15•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: mozilla1.0.1 → mozilla1.0
Comment 16•23 years ago
|
||
Comment on attachment 72299 [details] [diff] [review]
Patch
cool! we have keyboard accessibility!
r=ssu
Attachment #72299 -
Flags: review+
Comment 17•23 years ago
|
||
this looks good, except for the change to searchTermOverlay.dtd
I think that will case problems in the advanced message search dialog and the
advanced addressbook search dialog.
http://www.mozilla.org/mailnews/specs/search/images/Search1b.gif
http://www.mozilla.org/mailnews/specs/addressbook/images/AdvSearch1.gif
http://www.mozilla.org/mailnews/specs/filters/images/Filter2.gif
jglick, should all these dialogs look the same? If so, which dialogs should change?
sr=sspitzer for everything else besides the change to searchTermOverlay.dtd
If this is possible, don't check that part in, but check the rest in.
make sure to test well (and to test with out the serachTermOverlay.dtd part.)
For the searchTermOverlay.dtd part, we need jglick to decide how similar these
three dialogs should be.
Comment 18•23 years ago
|
||
Håkan was trying to fix the fact that the word "match" is duplicated in the
Filter Rules dialog.
So the same text strings are being used for the radio buttons in these three
dialogs?
If that is the case, leave the radio buttons as "Match all of the following" and
"Match any of the following" for the three windows/dialogs.
The descriptive text above the radio buttons for Filter Rules needs to be
changed from "For incoming messages that match:" to "For incoming message that:"
so that the word "match" isn't repeated.
Assignee | ||
Comment 19•23 years ago
|
||
Without the searchTermOverlay changes. I'll attach a patch later to fix
jglick's wording nit.
Attachment #72299 -
Attachment is obsolete: true
Assignee | ||
Updated•23 years ago
|
Summary: Filter UI: mnemonics → Make the filter UI accessible
Assignee | ||
Comment 20•23 years ago
|
||
Comment on attachment 72775 [details] [diff] [review]
Patch v2
Carrying over the reviews.
Attachment #72775 -
Flags: superreview+
Attachment #72775 -
Flags: review+
Assignee | ||
Comment 21•23 years ago
|
||
Seth, if it's OK with you, I'll just sneak in this tiny change into the final
patch (which will fix jglick's nit):
FilterEditor.dtd:
-<!ENTITY conditionDesc.label "For incoming messages that match:">
+<!ENTITY conditionDesc.label "For incoming messages that:">
Comment 22•23 years ago
|
||
Comment on attachment 72775 [details] [diff] [review]
Patch v2
a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #72775 -
Flags: approval+
Assignee | ||
Comment 23•23 years ago
|
||
fixed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 24•23 years ago
|
||
Filter rules "Filter name" field mnemonic is shown in spec as f, in today's
build as i -- Any problem with that jglick, anyone?
Comment 25•23 years ago
|
||
http://www.mozilla.org/mailnews/specs/filters/images/Filter2.gif
Laurel, I see "i" being used. Am i missing something?
Reporter | ||
Comment 26•23 years ago
|
||
Guess I was seeing things. Marking verified wiht mar08 commercial trunk.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•