Closed Bug 40761 Opened 25 years ago Closed 23 years ago

Make the filter UI accessible

Categories

(MailNews Core :: Filters, defect)

defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.0

People

(Reporter: laurel, Assigned: hwaara)

References

(Blocks 1 open bug)

Details

(Keywords: polish)

Attachments

(1 file, 1 obsolete file)

refer to message filters ui spec: http://gooey/client/5.0/specs/mail/filters/Filters.html Mnenmonics have been added in the current revision of the filter ui spec. Please implement -- Win32 for sure. What about linux? 4.x had mnemonics in menus, but not in dialogs (at least I haven't found any). Mac not applicable.
QA Contact: lchiang → laurel
Summary: Filter UI: mnemonics → Filter UI: mnemonics
everything is cross-platform, even mneomimcs, I couldn't implement it on 'just win32' if I tried :)
Status: NEW → ASSIGNED
Target Milestone: --- → M20
->gayatrib
Assignee: alecf → gayatrib
Status: ASSIGNED → NEW
Component: Mail Window Front End → Filters
OS -> All Platform -> All
OS: Linux → All
Hardware: PC → All
reassigning to naving
Assignee: gayatrib → naving
Jglick, are all the mnemonics up to date?
Keywords: polish, ui
http://www.mozilla.org/mailnews/specs/filters/ Yeah, mnemonics are all there except "New Folder" on Filter Runs. "N" seems to be available for that.
Jglick, I talked to trudelle. Were you aware that accesskey support is not implemented for XUL, but only for HTML? Are you even able to trigger an accesskey? Seems like all our "support" for accesskeys in Mailnews is totally bogus!
No I was not aware. Guess this will have to wait.
jglick: that (implemention of accesskeys for XUL) is bug 959 if you are interested.
Taking
Assignee: naving → hwaara
triaging
Severity: normal → minor
Priority: P3 → P4
Target Milestone: --- → Future
Priority: P4 → P3
Priority: P3 → --
Target Milestone: Future → mozilla1.0.1
Ssu, wanna take this too? :-)
hwaawa, did trudelle mention which bug would fix access keys in xul? I'm gessing it might be the infamous bug 959.
Yes, that's the one. Poke jag so he will make a new patch and check it in. :-)
Depends on: Accesskey-XUL
Attached patch Patch (obsolete) (deleted) — Splinter Review
Now that bug 959 is fixed, this makes sense to fix. This adds accesskeys to all filter controls, per the spec. I also fixed a wording that was not according to the spec. Note that until bug 90406 is resolved, accesskeys don't work for radiobuttons.
Status: NEW → ASSIGNED
Target Milestone: mozilla1.0.1 → mozilla1.0
Comment on attachment 72299 [details] [diff] [review] Patch cool! we have keyboard accessibility! r=ssu
Attachment #72299 - Flags: review+
this looks good, except for the change to searchTermOverlay.dtd I think that will case problems in the advanced message search dialog and the advanced addressbook search dialog. http://www.mozilla.org/mailnews/specs/search/images/Search1b.gif http://www.mozilla.org/mailnews/specs/addressbook/images/AdvSearch1.gif http://www.mozilla.org/mailnews/specs/filters/images/Filter2.gif jglick, should all these dialogs look the same? If so, which dialogs should change? sr=sspitzer for everything else besides the change to searchTermOverlay.dtd If this is possible, don't check that part in, but check the rest in. make sure to test well (and to test with out the serachTermOverlay.dtd part.) For the searchTermOverlay.dtd part, we need jglick to decide how similar these three dialogs should be.
Blocks: accesskey
Håkan was trying to fix the fact that the word "match" is duplicated in the Filter Rules dialog. So the same text strings are being used for the radio buttons in these three dialogs? If that is the case, leave the radio buttons as "Match all of the following" and "Match any of the following" for the three windows/dialogs. The descriptive text above the radio buttons for Filter Rules needs to be changed from "For incoming messages that match:" to "For incoming message that:" so that the word "match" isn't repeated.
Attached patch Patch v2 (deleted) — Splinter Review
Without the searchTermOverlay changes. I'll attach a patch later to fix jglick's wording nit.
Attachment #72299 - Attachment is obsolete: true
Summary: Filter UI: mnemonics → Make the filter UI accessible
Comment on attachment 72775 [details] [diff] [review] Patch v2 Carrying over the reviews.
Attachment #72775 - Flags: superreview+
Attachment #72775 - Flags: review+
Seth, if it's OK with you, I'll just sneak in this tiny change into the final patch (which will fix jglick's nit): FilterEditor.dtd: -<!ENTITY conditionDesc.label "For incoming messages that match:"> +<!ENTITY conditionDesc.label "For incoming messages that:">
Comment on attachment 72775 [details] [diff] [review] Patch v2 a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #72775 - Flags: approval+
fixed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Filter rules "Filter name" field mnemonic is shown in spec as f, in today's build as i -- Any problem with that jglick, anyone?
http://www.mozilla.org/mailnews/specs/filters/images/Filter2.gif Laurel, I see "i" being used. Am i missing something?
Guess I was seeing things. Marking verified wiht mar08 commercial trunk.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: