Closed Bug 40780 Opened 25 years ago Closed 24 years ago

Apply max-height to .progress-text not progressmeter

Categories

(SeaMonkey :: UI Design, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jrgmorrison, Assigned: nbhatla)

Details

Attachments

(1 file)

From bug #39681, here is a proposed change to the structural CSS for progressmeters. It moves the 'max-height:' property from the containing <progressmeter> and instead applies it to the <xul:text> element inside the binding (class .progress-text). The patch covers the four global.css for the modern and per-platform classic themes. Without this change, the progressmeter itself is restricted to the max-height, but the elements within the internal stack are not. So, apply max-height to the only element that has intrinsic height. [On the other hand, I'm not sure why the progressmeter <box> is not constraining the heights of its children, but ... whatever). There is still the issue of why certain CSS selectors that should not match the text element, are matching it, but that is left to bug #39681 Index: themes/modern/global/global.css =================================================================== RCS file: /cvsroot/mozilla/themes/modern/global/global.css,v retrieving revision 1.7 diff -c -r1.7 global.css *** themes/modern/global/global.css 2000/05/15 09:42:26 1.7 --- themes/modern/global/global.css 2000/05/27 00:00:33 *************** *** 150,156 **** min-width : 100px; margin : 0px 4px 0px 4px; border : 1px inset #CCCCCC; - max-height : 1.5em; } progressmeter > .progressmeter-internal-box --- 150,155 ---- *************** *** 168,173 **** --- 167,177 ---- .progress-remainder { background-color : #999999; + } + + .progress-text + { + max-height : 1.5em; } /** XUL <scrollbar> element **/ Index: themes/classic/global/win/global.css =================================================================== RCS file: /cvsroot/mozilla/themes/classic/global/win/global.css,v retrieving revision 1.3 diff -c -r1.3 global.css *** themes/classic/global/win/global.css 2000/05/25 06:04:38 1.3 --- themes/classic/global/win/global.css 2000/05/27 00:00:33 *************** *** 153,159 **** min-width : 100px; margin : 0px 4px 0px 4px; border : 1px inset #CCCCCC; - max-height : 1.5em; } progressmeter > .progressmeter-internal-box --- 153,158 ---- *************** *** 171,176 **** --- 170,180 ---- .progress-remainder { background-color : #999999; + } + + .progress-text + { + max-height : 1.5em; } /** XUL <scrollbar> element **/ Index: themes/classic/global/unix/global.css =================================================================== RCS file: /cvsroot/mozilla/themes/classic/global/unix/global.css,v retrieving revision 1.1 diff -c -r1.1 global.css *** themes/classic/global/unix/global.css 2000/05/23 04:03:56 1.1 --- themes/classic/global/unix/global.css 2000/05/27 00:00:33 *************** *** 150,156 **** min-width : 100px; margin : 0px 4px 0px 4px; border : 1px inset #CCCCCC; - max-height : 1.5em; } progressmeter > .progressmeter-internal-box --- 150,155 ---- *************** *** 168,173 **** --- 167,177 ---- .progress-remainder { background-color : #999999; + } + + .progress-text + { + max-height : 1.5em; } /** XUL <scrollbar> element **/ Index: themes/classic/global/mac/global.css =================================================================== RCS file: /cvsroot/mozilla/themes/classic/global/mac/global.css,v retrieving revision 1.1 diff -c -r1.1 global.css *** themes/classic/global/mac/global.css 2000/05/23 04:03:53 1.1 --- themes/classic/global/mac/global.css 2000/05/27 00:00:33 *************** *** 150,156 **** min-width : 100px; margin : 0px 4px 0px 4px; border : 1px inset #CCCCCC; - max-height : 1.5em; } progressmeter > .progressmeter-internal-box --- 150,155 ---- *************** *** 168,173 **** --- 167,177 ---- .progress-remainder { background-color : #999999; + } + + .progress-text + { + max-height : 1.5em; } /** XUL <scrollbar> element **/
Attached file patch to global.css (times four) (deleted) —
Keywords: patch
The modern, win-classic, and unix-classic skins have removed the use of max-height: with the progressmeter. However, this remains in the mac-classic skin. The above is still a correct fix for that skin, although, you can just drop the use of max-height: altogether (if I'm not mistaken). Reassigning to nbhatla for the mac-classic skin.
Assignee: ben → nbhatla
cc'ing paul chen (who i thought was working on this :-)...
nm: pchen's no longer working on this feature...
Status: NEW → ASSIGNED
applied patch to mac classic skin. Marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
feel free to verify these bugs if i don't get to 'em beforehand. if you do, pls remove the verifyme keyword when you do verify such a bug. thx!
Keywords: verifyme
marking vrfy'd. fixed a while back...
Status: RESOLVED → VERIFIED
Keywords: verifyme
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: