Closed Bug 40786 Opened 25 years ago Closed 24 years ago

Binary not replaced when file is in use

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

PowerPC
Mac System 9.x

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jimmykenlee, Assigned: dbragg)

Details

(Keywords: platform-parity, Whiteboard: [nsbeta2+])

Build: 2000-05-26-08-M16(MAC) 1. From http://jimbob/trigger3.html, enter f_addfile_macsmpltxt.xpi and click Trigger button 2. Launch SimpleText from the subdirectory, simpletext_subdir 3. From http://jimbob/trigger3.html, enter f_addfile_macsmpltxt_inus.xpi and click Trigger button RESULT: The first install succeeds. This file is 60k version 1.3.1. The second install names the file "decode" with file size 120k version 1.4. The file, SimpleText, does not get replaced by the second installation. The install.log erroneously reports -214 which is being tracked by Bug 40783. EXPECTED RESULT: Binary file is replaced by second installation after the in-use file session ends.
Nominating as nsbeta 2. This fix is necessary to enable us to upgrade to Beta3 successfully. Adding pp since this occurs only on the Macintosh platform.
Keywords: nsbeta2, pp
[nsbeta2+]
Whiteboard: [nsbeta2+]
Reassigning to Don for load balancing
Assignee: dveditz → dbragg
Fixed. The Mac version of NS_NewLocalFile will not take a "" as the first parameter. (The compiler takes it but runtime returns an invalid path error). Also, the path variables were not initialized before they were filled in from the registry. This resulted in garbage at the end of the path so the path wasn't found. Used memset to initialize the srcFile and doomedFile char arrays.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Build: 6/30/00 last build It now crashes during the second installation or replacement. Reopening Bug. No Macsbug report attached. My system won't seem to create it right now. You should have no problem reproducing the crash as originally described.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Per our discussion (and that it works for me and Samir and David ;-) Marking WORKSFORME.
Status: REOPENED → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → WORKSFORME
Reopening so it can be marked "fixed". (To keep the bug find/fix statistics in order.)
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Ok. It's fixed (still).
Status: REOPENED → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
Build: 2000-07-05-10-M17(MAC) It's ok with me. Marking Verified!
Status: RESOLVED → VERIFIED
fixing null OS field on old bugs
OS: Mac System 9.x
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.