Closed
Bug 41519
Opened 25 years ago
Closed 25 years ago
bugzilla won't let me vote: "Wrong login. The login got confused."
Categories
(Bugzilla :: Bugzilla-General, defect, P3)
Bugzilla
Bugzilla-General
Tracking
()
VERIFIED
FIXED
Bugzilla 2.12
People
(Reporter: dgm, Assigned: endico)
References
()
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
I've tried to vote for the first time. Each time I try to submit a vote, I get
the following page:
"Wrong login.
The login info got confused. If you want to adjust the votes for
dgm@altavista.net, then please click here."
And the provide link obviously doesn't help, as I haven't got any votes to
adjust yet!
Comment 1•25 years ago
|
||
I'm also getting this. Tried Lynx as well, so it's not Mozilla.
Comment 2•25 years ago
|
||
I'm getting this, too, and I'm running Communicatior 4.61 on Linux, so
I think Platform and OS should be adjusted to all/all.
Comment 3•25 years ago
|
||
Raising severity since voting can't be done at all.
Severity: normal → major
OS: Windows 98 → All
Hardware: PC → All
Assignee | ||
Comment 4•25 years ago
|
||
cyeh, I wonder if this has to do with the update to bugzilla friday.
Assignee | ||
Comment 5•25 years ago
|
||
It looks like the May 8 change to validate $::FORM{'who'} is the culprit.
Shouldn't that throw an exception if it finds bad data?
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=CGI.pl&root=/cvsroot&subdir=mozilla/webtools/bugzilla&command=DIFF_FRAMESET&rev1=1.65&rev2=1.66
Assignee | ||
Comment 6•25 years ago
|
||
Assignee | ||
Comment 7•25 years ago
|
||
This probably isn't the proper fix but it lets you vote.I'm not sure how
$::FORM{'who'} was supposed to have been set. I hate to remove that bit
of sanity checking. It was probably there for a good reason.The real problem
is probably in (or is uncovered by) the new code in CGI.pm. in the diff above.
Comment 8•25 years ago
|
||
In the interest of eschewing obfuscation, "if ( (! defined $who) || (!$who) ) {"
can be written "unless ($foo) {".
Comment 9•25 years ago
|
||
Except, of course, it should be "who" not "foo". duh.
Comment 10•25 years ago
|
||
*** Bug 41662 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 12•25 years ago
|
||
I checked in the fix for this, updated bugzilla.mozilla.org and tested
successfully by voting for this bug. Decklin, I didn't follow your
suggestion because you left out the test for checking whether $who is
defined. After adding that back in, the code isn't any less obfusticated.
Thanks, tho. Marking Fixed.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Comment 13•25 years ago
|
||
Dawn do you still think this isn't the proper fix? Should a bug be raised on
doing the proper fix?
Comment 14•24 years ago
|
||
*** Bug 65033 has been marked as a duplicate of this bug. ***
Comment 15•24 years ago
|
||
*** Bug 67360 has been marked as a duplicate of this bug. ***
Comment 16•24 years ago
|
||
In search of accurate queries.... (sorry for the spam)
Target Milestone: --- → Bugzilla 2.12
Comment 18•23 years ago
|
||
Moving closed bugs to Bugzilla product
Component: Bugzilla → Bugzilla-General
Product: Webtools → Bugzilla
Version: other → unspecified
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•