We should draw focus rings for single and multi-line text fields. There used to be clipping bugs that made this difficult but those appear to be gone now.

This works well but I need to test on 10.4. I can do that in the next day or two.

> There used to be clipping bugs ... but those appear to be gone now Does that mean bug 414994 should be marked as WFM?

(In reply to comment #2) > > There used to be clipping bugs ... but those appear to be gone now > > Does that mean bug 414994 should be marked as WFM? Not sure. That bug has to do with buttons, my comments here only pertain to text fields.

Comment on attachment 301234 [details] [diff] [review] fix v1.0 This looks fine to me (though I haven't tested it).

Hmm ... the patch looks fine, but why does it work? If I have <style>span:hover { outline:2px solid green; }</style> <input type="text"><span>Hello</span> Does focusing the input and then adding/removing the span's outline paint the focus ring correctly?

Comment on attachment 301234 [details] [diff] [review] fix v1.0 This is probably worth taking. It is a commonly complained-about issue on the Mac. Roc - that test case you posted works fine. I don't see how this code is different from any other focus ring drawing we do.

landed on trunk

the width of the focus ring for multiline text fields is wrong, above patch fixes that

landed fix width v1.0 as a minor tweak to the already reviewed and approved patch, still requesting post-landing sr from roc to be safe

I've been running into a wacky-ass cosmetic glitch with this since it landed. It involves stacked text fields (single and multiple lines) and I only see it in Livejournal comment threads when I'm logged in (that is to say, when the fields are revealed with a Javascript link instead of residing on a separate page). Here's a screenshot, and I'll try to narrow it down to a testcase.

(In reply to comment #12) That looks like the same issue as bug 416929.

Oop, it is. Thanks for the heads-up!