Closed
Bug 4631
Opened 26 years ago
Closed 26 years ago
[PP]gcc 2.7.2.3 barfage on wallet.cpp
Categories
(Core :: XUL, defect, P3)
Tracking
()
VERIFIED
FIXED
People
(Reporter: newt, Assigned: morse)
Details
Sources pulled 6 Apr 1999 20:00 PST; compiling with gcc 2.7.2.3 under Linux
2.0.36 (Slackware/libc5):
wallet.cpp:172: fixed or forbidden register was spilled.
This may be due to a compiler bug or to impossible asm
statements or clauses.
cpp: output pipe has been closed
make[3]: *** [wallet.o] Error 1
make[3]: Leaving directory `/util/www/mozilla/extensions/wallet/src'
This is wallet_DumpTiming(), which looks pretty harmless to me at first glance,
but who knows. If it is a gcc bug, this means the Unix build instructions need
to be updated--i.e., 2.7.2.3 is no longer an option. (My last pull was 14 Mar,
which built successfully.)
Reporter | ||
Comment 1•26 years ago
|
||
Sorry, I failed to include the type mismatch warning just before the error; the
following trivial patch fixes the problem:
--- wallet.cpp.stock Tue Apr 6 17:48:46 1999
+++ wallet.cpp Wed Apr 7 07:02:30 1999
@@ -162,7 +162,7 @@
PRInt32 i;
for (i=1; i<timing_index; i++) {
#ifndef XP_MAC
- fprintf(stdout, "time %c = %ld\n", timingID[i], (timings[i] -
timings[i-1])/100);
+ fprintf(stdout, "time %c = %ld\n", timingID[i], (long)(timings[i] -
timings[i-1])/100);
#endif
if (i%20 == 0) {
wallet_Pause();
Assignee | ||
Updated•26 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•26 years ago
|
||
This code is wrapped inside an ifdef DEBUG so apparently it is breaking the
debug build only, and the release build is fine. In that case it's not critical
to fix this before the M4 release (which is already frozen). I will make the
fix just as soon as M4 branches and the freeze is over.
Summary: gcc 2.7.2.3 barfage on wallet.cpp → [PP]gcc 2.7.2.3 barfage on wallet.cpp
Assignee | ||
Updated•26 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 3•26 years ago
|
||
Fixed as indicated and checked in.
Comment 4•26 years ago
|
||
newt, is all well for you? Please mark verified if you can build now.
Reporter | ||
Updated•26 years ago
|
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 5•26 years ago
|
||
Sorry, I didn't realize this was still considered open! All is fine; marking
verified.
You need to log in
before you can comment on or make changes to this bug.
Description
•