Closed Bug 4677 Opened 26 years ago Closed 25 years ago

Extra space between images

Categories

(Core :: Layout, defect, P2)

defect

Tracking

()

VERIFIED DUPLICATE of bug 5821

People

(Reporter: njames, Assigned: buster)

References

()

Details

(Whiteboard: [TESTCASE])

Attachments

(2 files)

This page http://animatedgifs.simplenet.com/ the right frame loaded the counter was a little high, but the left frame did not load. It has animated gifs on it they will not work.
Summary: Left frame doesn't load
Assignee: troy → karnaze
Component: Layout → HTMLFrames
Summary: Left frame doesn't load → Right frame doesn't load
Chris, the right frame cell doesn't display. Actually, it displayed very briefly and then it disappeared. Something very strange is going on. Maybe related to the JavaScript on the page
Assignee: karnaze → vidur
Severity: major → critical
Priority: P3 → P2
Summary: Right frame doesn't load → [OPT CRASH] Right frame doesn't load
Target Milestone: M5
The right frame loaded on my 4/10 debug WinNT. It crashed on my 4/10 optimized WinNT with MOZ_PROFILE set to 1. In the stack below, StyleSetImpl::ContentRemoved had the following line where aContainer=null causing the crash, aChild is an nsHTMLHtmlElement and aIndexInContainer=0. Reassigning to Vidur, changing the summary to reflect an optimized crash and marking critical for M5. return mFrameConstructor->ContentRemoved(aPresContext, aContainer, aChild, aIndexInContainer); ---stack---- nsCSSFrameConstructor::ContentRemoved(nsCSSFrameConstructor * const 0x00746e40, nsIPresContext * 0x007503c0, nsIContent * 0x00000000, nsIContent * 0x0073b1cc, int 0) line 3948 + 6 bytes StyleSetImpl::ContentRemoved(StyleSetImpl * const 0x00746df0, nsIPresContext * 0x0073c540, nsIContent * 0x00000000, nsIContent * 0x0073b1cc, int 0) line 767 PresShell::ContentRemoved(PresShell * const 0x00496f75, nsIDocument * 0x00746e98, nsIContent * 0x0073b680, nsIContent * 0x00000000, int 7582156) line 1787 nsDocument::ContentRemoved(nsDocument * const 0x0073b680, nsIContent * 0x00000000, nsIContent * 0x0073b1cc, int 0) line 1522 + 32 bytes nsHTMLDocument::ContentRemoved(nsHTMLDocument * const 0x0073b680, nsIContent * 0x00000000, nsIContent * 0x0073b1cc, int 0) line 685 nsDocument::Reset(nsDocument * const 0x0012f934, nsIURL * 0x00779dd0) line 824 nsHTMLDocument::Reset(nsHTMLDocument * const 0x0012f934, nsIURL * 0x00779dd0) line 222 nsHTMLDocument::Open(nsHTMLDocument * const 0x0073b720, JSContext * 0x0073c6e0, long * 0x011aef4c, unsigned int 1) line 1169 nsHTMLDocument::WriteCommon(nsHTMLDocument * const 0x0012f934, JSContext * 0x0073c6e0, long * 0x011aef4c, unsigned int 1, int 0) line 1243 + 26 bytes nsHTMLDocument::Write(nsHTMLDocument * const 0x0054ee26, JSContext * 0x0073b720, long * 0x0073c6e0, unsigned int 18542412) line 1282 HTMLDocumentWrite(JSContext * 0x0073c6e0, JSObject * 0x0112fc80, unsigned int 1, long * 0x011aef4c, long * 0x0012fb78) line 714 + 18 bytes js_Invoke(JSContext * 0x0073c6e0, unsigned int 1, int 0) line 650 + 17 bytes js_Interpret(JSContext * 0x0073c6e0, long * 0x0012fde8) line 2184 js_Execute(JSContext * 0x00000000, JSObject * 0x0112ee18, JSScript * 0x00779910, JSFunction * 0x00000000, JSStackFrame * 0x00000000, int 0, long * 0x0012fde8) line 817 JS_EvaluateUCScriptForPrincipals(JSContext * 0x0073c6e0, JSObject * 0x0112ee18, JSPrincipals * 0x00000000, unsigned short * 0x007794f0, unsigned int 206, char * 0x007161d0, unsigned int 0, long * 0x0012fde8) line 2322 + 19 bytes nsJSContext::EvaluateString(nsJSContext * const 0x80000001, const nsString & {" document.write('<a href="http://ads.burstnet.com/ads/ad3099a-map.cgi/8244/BCPG1996.2527.4146/" target=_top><img src="http://"}, char * 0x007161d0, unsigned int 0, nsString & {""}, int * 0x0012fe5c) line 122 + 50 bytes HTMLContentSink::EvaluateScript(HTMLContentSink * const 0x0012f934, nsString & {" document.write('<a href="http://ads.burstnet.com/ads/ad3099a-map.cgi/8244/BCPG1996.2527.4146/" target=_top><img src="http://"}, int 0) line 2779 nsDoneLoadingScript(nsIUnicharStreamLoader * 0x00333d4c, nsString & {"?3?3?3?3?3?3?3?3?3"}, void * 0x00756890, unsigned int 7581952) line 2802 nsUnicharStreamLoader::OnStopBinding(nsUnicharStreamLoader * const 0x01233d78, nsIURL * 0x00756844, unsigned int 7693424, unsigned short * 0x00000000) line 155 + 21 bytes nsDocumentBindInfo::OnStopBinding(nsDocumentBindInfo * const 0x007568a0, nsIURL * 0x00756470, unsigned int 0, unsigned short * 0x007798a0) line 1992 + 15 bytes OnStopBindingProxyEvent::HandleEvent(OnStopBindingProxyEvent * const 0x003328a3) line 592 StreamListenerProxyEvent::HandlePLEvent(PLEvent * 0x002518ee) line 472 PL_HandleEvent(PLEvent * 0x0025186a) line 476 + 4 bytes PL_ProcessPendingEvents(PLEventQueue * 0x00251b18) line 438 _md_EventReceiverProc(void * 0x77e71250, unsigned int 22676406, unsigned int 49329, long 0) line 799 + 10 bytes USER32! 77e71250() main(int 4236559, char * * 0x00000001) line 103 mainCRTStartup + 255 bytes KERNEL32! 77f1b304()
Assignee: vidur → karnaze
Summary: [OPT CRASH] Right frame doesn't load → incorrect frame layout
Fixed my part of the bug with a checkin on 4/13. The reason the problem occurred on the optimized build was because it was timing related. The original bug with the counter laying out a bit high still exists. Actually, the counter is in a separate frame and the frame is laying out incorrectly.
Severity: critical → normal
Status: NEW → ASSIGNED
Moving to M6
Target Milestone: M5 → M6
Moving to M8
Assignee: karnaze → pollmann
Status: ASSIGNED → NEW
Reassigning frameset/iframe bugs to Eric.
Component: HTMLFrames → Layout
Summary: incorrect frame layout → Extra space between images
Whiteboard: [TESTCASE]
This is not (or no longer) a frameset problem. The problem is not the counter's position, the problem is that the upper-left frame's content is taking more space than expected. The problem is, when an image is encapsulated in a style element, like an anchor then some extra space is left after it. In my testcase I use <b>, not an anchor so the testcase is simpler. Here's the testcase, I'm also attaching it for easier viewing from the browser ---- <b><img src="x.gif" width=100 height=100 alt="Picture1"></b><br> <img src="x.gif" width=100 height=100 alt="Picture2"> ---- I'm also changing the summary, and the component to Layout.
Attached file Testcase (deleted) —
Attached file Another test case... (deleted) —
Assignee: pollmann → troy
OS: Windows 98 → All
Hardware: PC → All
I've slightly modified the test case to make things more clear. It now includes three vertically stacked images (/ant.jpg). The first image is enclosed in a bold tag, and has, incorrectly, three pixels of vertical space following it. The next one is not enclosed in bold, and has no vertical space following it. I'm not sure who this should go to, but it appears to be a basic layout issue. Troy, can you take a look?
Status: NEW → ASSIGNED
Target Milestone: M8 → M9
Assignee: troy → kipp
Status: ASSIGNED → NEW
This is basically the same problem as 5610, except this example uses a B tag instead of a A tag. This is a simpler example, so I'm marking 5610 a DUP of this bug
*** Bug 5610 has been marked as a duplicate of this bug. ***
Kipp, I've seen a few of this type of problem and it looks like a line layout issue involving BR and inline elements (B or A for example) that causes extra spacing between lines
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → DUPLICATE
Yet another duplicate of bug 5821. *** This bug has been marked as a duplicate of 5821 ***
Status: RESOLVED → VERIFIED
Agreed. This is a duplicate of 5821.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: