Closed Bug 46870 Opened 24 years ago Closed 23 years ago

nsIWebNavigation::LoadURI() needs to accept a post stream.

Categories

(Core Graveyard :: Embedding: APIs, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED DUPLICATE of bug 94205
mozilla0.9.5

People

(Reporter: jud, Assigned: pollmann)

References

Details

(Keywords: embed, Whiteboard: [nsbeta3-])

Attachments

(3 files)

-Requirement for a way to Get the post data from a form in the current document -Specify the post data as a parameter to LoadURI -Doug says that the work might already be done. Thread in n.p.m.embedding related to this. -Need a public API for getting and setting post data.
Keywords: embed
CC'ing Radha - did you already do work in this area to get session history to store the post data for URL's?
Keywords: nsbeta3
Marking nsbeta3-
Whiteboard: [nsbeta3-]
SessionHistory already stores postdata for urls. But I think this may be related to 32293. 32293 is nsbeta3+. So I would like know that this bug's real intention was, so that we can decide if this can be nsbeta3- or +.
Jud, is there any specific work that needs to be done in the beta3 time frame? nsbeta3- == Future, setting milestone to that unless I hear otherwise
Status: NEW → ASSIGNED
Target Milestone: --- → Future
Set milestone to mozilla0.8
Target Milestone: Future → mozilla0.8
Updating QA Contact
QA Contact: jrgm → mdunn
Moving to Mozilla0.9
Target Milestone: mozilla0.8 → mozilla0.9
*** Bug 68590 has been marked as a duplicate of this bug. ***
Target Milestone: mozilla0.9 → mozilla0.9.1
Correction: Changing QA contact for the Embed API bugs to David Epstein.
QA Contact: mdunn → depstein
Target Milestone: mozilla0.9.1 → mozilla0.9.2
Attached patch patch 1 (deleted) — Splinter Review
This patch allows a post stream to be passed into nsIWebNavigation::LoadURI(). It does *not* address the other stated need of this bug, to "Get the post data from a form in the current document". Jud, can you provide an explanation of what is meant by this? Do you mean the postdata that was sent to the server to get the current page (if it was the result of a post)? Do you mean you want to save the state of form controls of a given form / all forms on the current page? ??? CC'ing Adam because the meat of this change so far is in the DocShell and it's APIs. I don't know/remember what this was needed for, but just as a reminder, posting the same form twice to the server can be dangerous and the user should always be warned and given a chance to cancel this operation before it happens!
OS: Windows 98 → All
Hardware: PC → All
Changes look good, except for those to the internal version of LoadURI. Would it make sense to make postdata a member of the loadinfo object rather than an extra parameter?
Attached patch patch 2 (deleted) — Splinter Review
Adam, patch 2 removes the new param from the internal LoadURI and adds a postDataStream member to the load info, as you suggest. Does this look better?
Looks good, r=adamlock
Target Milestone: mozilla0.9.2 → mozilla0.9.3
The patch needs to be updated a bit... For one thing, we now have nsDocShellLoadInfo::GetPostDataStream and nsDocShellLoadInfo::SetPostDataStream so this patch doesn't have to create them....
Didn't make 0.9.3.
Target Milestone: mozilla0.9.3 → mozilla0.9.4
Depends on: 94205
Target Milestone: mozilla0.9.4 → mozilla0.9.5
This work is now being tracked by bug #94205. *** This bug has been marked as a duplicate of 94205 ***
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
verifying as dupe of bug 94205.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: