Closed
Bug 4781
Opened 26 years ago
Closed 25 years ago
[PP][BLOCKER] GTK Borderless top-level windows
Categories
(Core :: Layout: Form Controls, defect, P3)
Tracking
()
VERIFIED
FIXED
M7
People
(Reporter: kmcclusk, Assigned: ramiro)
Details
Need to implment borderless top-level windows on Linux.
This is a blocker for frame-based combo boxes.
This is also a blocker for XPFE popup trees.
Assignee | ||
Updated•26 years ago
|
Status: NEW → ASSIGNED
Summary: [BLOCKER] GTK Borderless top-level windows → [BLOCKER] GTK Borderless top-level windows
Target Milestone: M5
kevin, ill look at this soon. Is this already turned on on windows so that I
can see what its supposed to do ? Where do i look ? thanks.
marking assigned m5.
Summary: [BLOCKER] GTK Borderless top-level windows → [PP][BLOCKER] GTK Borderless top-level windows
I can fix this one. We are going to need the precreatewidget info to have
something telling us that it is a toplevel window. once we have this, I can
have this done very quickly.
Comment 3•25 years ago
|
||
Feel free to add another enum to the BorderStyle something like:
eBorderStyle_BorderlessTopLevel
And the key off that in the create
I have a few questions,
look at
http://lxr.mozilla.org/seamonkey/source/layout/html/style/src/nsCSSFrameConstructor.cpp#2205
This indicates to me, that it is not being told to create a toplevel widget at
all. This leaves me to wonder how (or if) this is working under Windows or Mac?
In nsComboboxControlFrame::PaintComboboxControl
(http://lxr.mozilla.org/seamonkey/source/layout/html/forms/src/nsComboboxControlFrame.cpp#426)
Why is the code simply using a rendering context and drawing on it? I don't see
how this is going to draw on a "top level window" either?
Am I missing something?
Ok,
I went ahead and added eBorderStyle_BorderlessTopLevel, and added the supporting
gtk code. rods: could you (and/or whomever) add whatever is needed to the combo
box code (and other things) to make this work? thanks
Comment 9•25 years ago
|
||
Kevin is responsible for this work. He was going to have Patric Beard do the
view system work. Pierre was briefed on this before Kevin left. Pierre or Kevin
is your best answer. This should probably be moved to M6, because of Kevin being
gone.
Rod
Assignee | ||
Updated•25 years ago
|
Target Milestone: M5 → M6
Comment 10•25 years ago
|
||
marking m6.
Comment 11•25 years ago
|
||
Kevin, Pierre: Any progress here? I have done everything that I am aware of
needing to do... I would like to resolve this bug shortly...
Comment 12•25 years ago
|
||
reassigning to Kevin as there isn't much more I can do on this right now.
Reporter | ||
Comment 13•25 years ago
|
||
Patrick Beard, needs to do work in the view system to create the top-level
borderless windows, before I can use them for comboboxes.
Reporter | ||
Updated•25 years ago
|
Assignee: kmcclusk → beard
Reporter | ||
Comment 14•25 years ago
|
||
Patrick, I'm reassinging this to you. Once views can create top-level windows in
the XPCODE, reassign back to me and I'll test it with the combobox on Linux.
Updated•25 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M6 → M7
Reporter | ||
Comment 15•25 years ago
|
||
Ramiro, I am re-assigning this so you can confirm that the top-level borderless
windows work on Linux. If you bring up test5 or any other test with a combo box,
set the viewer to gfx-rendering mode, you can test that the top-level borderless
windows are functioning by clicking on a combo box to display it's drop-down
list. The drop down list is rendering in a top-level borderless window.
Reporter | ||
Updated•25 years ago
|
Assignee: beard → ramiro
Status: ASSIGNED → NEW
Assignee | ||
Updated•25 years ago
|
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Comment 16•25 years ago
|
||
This bug has been fixed. If anything remains to be done is platform specific
bugs which should get their own bug once kevin turns on gfx widgets.
phillip: you dont need to do anything.
marking fixed.
Comment 17•25 years ago
|
||
marking verified, per ramiro's comments
Comment 18•25 years ago
|
||
Moving all Widget Set bugs, past and present, to new HTML Form Controls
component per request from karnaze. Widget Set component will be retired
shortly.
You need to log in
before you can comment on or make changes to this bug.
Description
•