Closed Bug 4805 Opened 26 years ago Closed 25 years ago

[PP]Crash from corrupt history file

Categories

(Core Graveyard :: RDF, defect, P3)

x86
Linux

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: akkzilla, Assigned: waterson)

Details

Attachments

(1 file)

On Linux, run apprunner (no args). Type http://www.muzilla.org into the URL bar. Left-arrow or click to get the caret into the middle of the url. Hit the keypad enter key (not return). This inserts a garbage character into the url and then tries to go there, unsuccessfully. Exit via the menu. Now try to load apprunner again; it will crash on startup, with this stack trace: > #0 0x40dbd5f5 in nsHistoryDataSource::ReadOneHistoryFile > (this=0x8113428, > aStream=@0xbffff324, fileSpec={mPath = {mData = 0xbffff318}, > mError = 1088310344, _vptr. = 0x8113428}) > at > /builds/thu/mozilla/rdf/datasource/src/nsHistoryDataSource.cpp:658 > #1 0x40dbd421 in nsHistoryDataSource::ReadHistory (this=0x8113428) > at > /builds/thu/mozilla/rdf/datasource/src/nsHistoryDataSource.cpp:622 > #2 0x40dbce35 in nsHistoryDataSource::Init (this=0x8113428, > uri=0x400227f0 "rdf:history") > at > /builds/thu/mozilla/rdf/datasource/src/nsHistoryDataSource.cpp:477 > #3 0x40d706dc in ServiceImpl::GetDataSource (this=0x8126a60, > uri=0x400227f0 "rdf:history", aDataSource=0xbffff674) > at /builds/thu/mozilla/rdf/base/src/nsRDFService.cpp:857 > #4 0x4001e72d in nsGlobalHistory::Init (this=0x81266e0) > at /builds/thu/mozilla/xpfe/appshell/src/nsGlobalHistory.cpp:101 > #5 0x40017d8c in nsAppShellService::Initialize (this=0x8126280) > at /builds/thu/mozilla/xpfe/appshell/src/nsAppShellService.cpp:167 rm res/rdf/History/* will solve the problem; it's something in one of those files. (Sample corrupt history files have been sent to waterson.)
Status: NEW → ASSIGNED
Target Milestone: M5
Summary: Crash from corrupt history file → [PP]Crash from corrupt history file
Attached file akkana's corrupted history files (deleted) —
Wasn't checking strstr() for null pointer. Fix in hand.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Rewrote with appropriate paranoia.
Status: RESOLVED → VERIFIED
verified on redhat 5.2 i386 with build 1999-05-03-08
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: