Closed Bug 5032 Opened 26 years ago Closed 25 years ago

xpt_dump segfaults when given a non-xpt file

Categories

(Core :: XPCOM, defect, P5)

Product:
Core
Component:
XPCOM
Platform:
x86
All
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: mike+mozilla, Assigned: mike+mozilla)

Details

Attachments

(1 file)

patches for graceful failure from bad input .xpt file.
(deleted), patch
Details | Diff | Splinter Review
when called on an .idl file, xpt_dump dies with a segmentation fault. Looks like this could be a problem with libxpt.
Severity: normal → minor
Status: NEW → ASSIGNED
Priority: P3 → P5
QA Contact: 1679 → 423
Accepted bug, deflated priority, pulled vidur out of the QA Contact field.
Added mang. I have attached fixes for xpt_struct.c, xpt_dump.c and xpt_link.c to fail gracefully and print a reasonable error message when given a .xpt file with an invalid magic header. I'll spam the tree with these when M6 and xpcom/ open.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Checked in a fix. xpt_struct.c now detects a bad 'XPCOM TypeLib' header in the input file and fails gracefully, and xpt_link and xpt_dump now give informative error messages.
Component: xpidl → XPCOM
QA Contact: jband_mozilla → xpcom
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: