We can't currently let the gfx/src/nsDeviceContext code implement the LoadIcon method because it'll wipe out a unix or mac system with re-entrancy issues. As soon as netlib works properly on unix and mac please reassign this bug to troy/me. Also, related to this is the fact that we have grotty code to handle synchronous image updates that are probably due to the fact that because netlib has no thread on unix/mac we get a synchronous notify (for urls in the memory cache) because the marshalling code is not used. Two birds with one stone, hopefully.

Re-assigned to warren@netscape.com. Warren, this was assigned directly to Rick. What should I do with it?

I don't understand the issue. Is this a bug report to fix the networking problem, or something in gfx. If the former, then Rick should still be "it." If the latter, then don't give it to me.

Rick, can you advise me on this one?

Putting on [PP] radar.

Until netlib on mac and unix runs on its own thread, it can't do synchronous URL loading... This will be fixed by necko... I'm moving it to M9...

Changing all Networking Library/Browser bugs to Networking-Core component for Browser. Occasionally, Bugzilla will burp and cause Verified bugs to reopen when I do this in a bulk change. If this happens, I will fix. ;-)

I'm moving this to an M10 feature... We just need to clean up the nsDeviceContext code now that the threading model is consistent. --rick

Rod, since you are working on gfx these days I'm giving this to you - the issue is that LoadIcon in the gfx library needs to be implemented to do a synchronous load; when you have that working, please let troy know so that he can fixup the icon display in the image frame code. Thanks!

I don't any gfx changes are required. The function is LoadIconImage() and it's XP-code in the DeviceContextImpl class. Rod, you'll see this at the top of the function: // XXX synchronous image loading doesn't work on unix or mac yet // because netlib is not in its own thread. #if defined(XP_UNIX) || defined(XP_MAC) || defined(XP_BEOS) return NS_ERROR_FAILURE; #endif Once the Necko guys have synchronous loading working again (today it's broken on Windows as well), then I think all that needs to be done is remove the code I mentioned. I don't know when the Necko guys will have synchronous loading working. Rick Potts is the one to ask

Changing to M12

Don, Could you take a look at this, I don't have any idea what he is talking about?

Bulk move of all Networking-Core (to be deleted component) bugs to new Networking component.

This should be working.

marking verified