Closed Bug 5093 Opened 26 years ago Closed 26 years ago

[PP]mac only: thumb not moved when page is scrolled down

Categories

(Core Graveyard :: GFX, defect, P3)

Product:
Core Graveyard
Component:
GFX
Platform:
PowerPC
Mac System 8.5
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: cpratt, Assigned: beard)

Details

to reproduce this, go to a long page (macintouch.com works). press the space bar. the page (properly) scrolls down, but the thumb in the vertical scrollbar does not move down as well. expected behavior: the thumb moves down (to indicate that you are now further down on the page).
Assignee: michaelp → beard
Target Milestone: M6
-> M6
Status: NEW → ASSIGNED
Nor when you click pageUp or pageDown keys. This is simply a redraw bug. The scrollbar widget needs to be redrawn.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Fixed in nsScrollingView.cpp,3.102.
Pierre, should it be necessary to call Invalidate() after calling nsIScrollbar::SetPosition()? It seems to be on the Mac.
Status: RESOLVED → REOPENED
It shouldn't be necessary to call Invalidate() after nsIScrollbar::SetPosition(). It's a Mac-specific bug. Your fix in nsScrollingView.cpp is invalid. Instead, you should call Invalidate(PR_FALSE) in nsScrollbar::SetPosition(), just after setting mValue. Reopening.
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 26 years ago → 26 years ago
Resolution: --- → FIXED
The fix wasn't "invalid" it was just in the wrong place. I've rectified this. Removed fix from nsScrollingView.cpp (v3.103), added to nsScrollbar.cpp (v1.28).
Status: RESOLVED → VERIFIED
Fixed in the June 2 Build.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.