Closed
Bug 511682
Opened 15 years ago
Closed 15 years ago
Remove chromedir attributes, use -moz-locale-dir instead
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.1a1
People
(Reporter: philor, Assigned: philor)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
|
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
Once we kick 3.0 out the door and get off 1.9.1, we can remove the spew of chromedir="&locale.dir;" everywhere, and just use :-moz-locale-dir(rtl) instead of [chromedir="rtl"].
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs branch]
|
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #411132 -
Flags: review?(mkmelin+mozilla)
|
||
Updated•15 years ago
|
Attachment #411132 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Comment 2•15 years ago
|
||
Comment on attachment 411132 [details] [diff] [review]
Fix v.1
Nice! I think you missed a few global.dtd removals though
|
|
Assignee | |
Comment 3•15 years ago
|
||
The xhtml ones, where we included it and didn't include <body dir="&locale.dir;">? I tried to get Tomer to tell me whether we needed those missing dir attributes, but didn't succeed.
|
|
||
Comment 4•15 years ago
|
||
Yeah, can't think they would matter when they aren't referred to
And mail/base/content/extraCustomizeItems.xul.
|
|
Assignee | |
Comment 5•15 years ago
|
||
Yeah, they don't matter, but the question is whether or not we're broken because of them not mattering.
extraCustomizeItems.xul is another todo, because of the explicit |chromedir="ltr"| non-uses of global.dtd.
Sure would be nice if I knew whether or not we have even a single person testing nightlies in rtl.
|
|
Assignee | |
Comment 6•15 years ago
|
||
Bug 527888 for the search results one, because it sure is needed.
|
|
Assignee | |
Comment 7•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•