Closed
Bug 537219
Opened 15 years ago
Closed 14 years ago
Port |Bug 442730 - composition security options for encrypt should only be one menu item (with checkbox) like signing| to SeaMonkey
Categories
(SeaMonkey :: Security, defect)
SeaMonkey
Security
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1b2
People
(Reporter: sgautherie, Assigned: sgautherie)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•15 years ago
|
Summary: Port |Bug 442730 - composition security options for encrypt should only be one menu item (with checkbox) like signing| to SeaMlonkey → Port |Bug 442730 - composition security options for encrypt should only be one menu item (with checkbox) like signing| to SeaMonkey
|
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #419855 -
Flags: superreview?(neil)
Attachment #419855 -
Flags: review?(neil)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 419855 [details] [diff] [review]
(Av1) Just port it
[Checked in: See comment 7]
>+ gSMFields.requireEncryptMessage = !gSMFields.requireEncryptMessage;
>+
>+ if (gSMFields.requireEncryptMessage)
>+ {
>+ // Make sure we have a cert.
>+ if (!gCurrentIdentity.getUnicharAttribute("encryption_cert_name"))
>+ {
>+ gSMFields.requireEncryptMessage = false;
This is a bit ugly, but I guess it matches the ugly signing code...
>+ <menupopup id="optionsMenuPopup"
>+ onpopupshowing="setSecuritySettings(1);">
Can't do this, the options menu popup already has a popup showing handler.
>--- a/mailnews/extensions/smime/content/msgHdrViewSMIMEOverlay.js
>+++ b/mailnews/extensions/smime/content/msgHdrViewSMIMEOverlay.js
No real change here.
>--- a/mailnews/extensions/smime/content/msgHdrViewSMIMEOverlay.xul
>+++ b/mailnews/extensions/smime/content/msgHdrViewSMIMEOverlay.xul
Or here.
Attachment #419855 -
Flags: superreview?(neil)
Attachment #419855 -
Flags: review?(neil)
Attachment #419855 -
Flags: review-
|
||
Updated•15 years ago
|
|
|
Assignee | |
Comment 3•14 years ago
|
||
(In reply to comment #2)
> >+ <menupopup id="optionsMenuPopup"
> >+ onpopupshowing="setSecuritySettings(1);">
> Can't do this, the options menu popup already has a popup showing handler.
I filed bug 607583 to fix that.
|
|
Assignee | |
Comment 4•14 years ago
|
||
Comment on attachment 419855 [details] [diff] [review]
(Av1) Just port it
[Checked in: See comment 7]
Please, re-review, now that bug 607583 is fixed.
Attachment #419855 -
Flags: superreview?(neil)
Attachment #419855 -
Flags: review?(neil)
|
|
Assignee | |
Updated•14 years ago
|
Target Milestone: seamonkey2.1a1 → seamonkey2.1b2
|
|
||
Comment 5•14 years ago
|
||
(In reply to comment #3)
> (In reply to comment #2)
> > >+ <menupopup id="optionsMenuPopup"
> > >+ onpopupshowing="setSecuritySettings(1);">
> > Can't do this, the options menu popup already has a popup showing handler.
> I filed bug 607583 to fix that.
Sigh. That's actually a regression, since the quote message menuitem now doesn't always update when it should. Not that anyone's noticed...
|
|
||
Comment 6•14 years ago
|
||
Comment on attachment 419855 [details] [diff] [review]
(Av1) Just port it
[Checked in: See comment 7]
> <!ENTITY menu_securityEncryptRequire.label "Encrypt This Message">
> <!ENTITY menu_securityEncryptRequire.accesskey "E">
>
>-<!ENTITY menu_securityNoEncryption.label "Do Not Encrypt This Message">
>-<!ENTITY menu_securityNoEncryption.accesskey "N">
>-
> <!ENTITY menu_securitySign.label "Digitally Sign This Message">
>-<!ENTITY menu_securitySign.accesskey "S">
>+<!ENTITY menu_securitySign.accesskey "M">
Please post an appropriate announcement that these menuitems have moved and they may need new access keys. r=me without the unrelated changes.
Attachment #419855 -
Flags: superreview?(neil)
Attachment #419855 -
Flags: superreview+
Attachment #419855 -
Flags: review?(neil)
Attachment #419855 -
Flags: review+
|
|
Assignee | |
Comment 7•14 years ago
|
||
Comment on attachment 419855 [details] [diff] [review]
(Av1) Just port it
[Checked in: See comment 7]
http://hg.mozilla.org/comm-central/rev/472dbfde9ffd
Av1, with comment 6 suggestion(s).
Attachment #419855 -
Attachment description: (Av1) Just port it → (Av1) Just port it
[Checked in: See comment 7]
Attachment #419855 -
Flags: review-
|
|
Assignee | |
Updated•14 years ago
|
|
|
Assignee | |
Comment 8•14 years ago
|
||
(In reply to comment #6)
> Please post an appropriate announcement that these menuitems have moved and
> they may need new access keys.
I don't know what/where to post :-|
|
|
||
Comment 9•14 years ago
|
||
mozilla.dev.l10n (or its mailing list) perhaps?
|
|
Assignee | |
Comment 10•14 years ago
|
||
(In reply to comment #9)
> mozilla.dev.l10n (or its mailing list) perhaps?
Done.
You need to log in
before you can comment on or make changes to this bug.
Description
•