Closed
Bug 549580
Opened 15 years ago
Closed 15 years ago
If compose window initialisation fails, don't hide the error by throwing it to the text console
Categories
(Thunderbird :: Message Compose Window, defect)
Thunderbird
Message Compose Window
Tracking
(thunderbird3.0 .4-fixed)
RESOLVED
FIXED
Thunderbird 3.1b2
Tracking | Status | |
---|---|---|
thunderbird3.0 | --- | .4-fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
(deleted),
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Bienvenu
:
review+
standard8
:
approval-thunderbird3.0.4+
|
Details | Diff | Splinter Review |
Catching an error and dumping it to the text console just isn't nice. The compose window does this if it has an issue whilst opening. It displays a pretty dialog, but that's not much help to the user.
The code has support for printing an error message to the string, and all our locales do as well, but we just end up printing ""...
I think a chrome error in the dialog is likely to scare users - especially if its intermittent or rare, so just put the error into the error console, and if we get someone having persistent problems, then we can point them in the right direction.
I've got two patches to do this, one to change the string on trunk, the second to just change the dump location on the TB 3.0.x builds.
Attachment #429692 -
Flags: review?(philringnalda)
Assignee | ||
Comment 1•15 years ago
|
||
Attachment #429693 -
Flags: review?(philringnalda)
Assignee | ||
Comment 2•15 years ago
|
||
Phil: review ping.
Assignee | ||
Updated•15 years ago
|
Attachment #429692 -
Flags: review?(philringnalda) → review?(bienvenu)
Assignee | ||
Updated•15 years ago
|
Attachment #429693 -
Flags: review?(philringnalda) → review?(bienvenu)
Comment 3•15 years ago
|
||
Comment on attachment 429693 [details] [diff] [review]
3.0 branch patch
looks reasonable...
Attachment #429693 -
Flags: review?(bienvenu) → review+
Updated•15 years ago
|
Attachment #429692 -
Flags: review?(bienvenu) → review+
Assignee | ||
Comment 4•15 years ago
|
||
Checked in the trunk patch: http://hg.mozilla.org/comm-central/rev/884335fd11a0
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•15 years ago
|
||
Comment on attachment 429693 [details] [diff] [review]
3.0 branch patch
a=Standard8 for minor correctness fix that should help with debugging issues with users of released builds.
Attachment #429693 -
Flags: approval-thunderbird3.0.4+
Assignee | ||
Comment 6•15 years ago
|
||
Checked into 1.9.1: http://hg.mozilla.org/releases/comm-1.9.1/rev/0ba3c6dfdada
You need to log in
before you can comment on or make changes to this bug.
Description
•