Closed
Bug 5597
Opened 25 years ago
Closed 8 years ago
classes links are incorrect
Categories
(Webtools Graveyard :: MXR, defect, P3)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: sspitzer, Assigned: timeless)
References
()
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
kiko
:
review-
|
Details | Diff | Splinter Review |
I think I found a bug in MXR / LXR.
go here:
http://lxr.mozilla.org/seamonkey/ident?i=nsMailboxUrl
And you'll get:
Defined as a class in:
mailnews/local/src/nsMailboxUrl.h, line 27, inheriting
class nsIMailboxUrl
class nsINetlibURL
class nsIMsgUriUrl
the links for those classes all point to
http://lxr.mozilla.org/seamonkey/ident?i=nsIMailboxUrl
instead of
http://lxr.mozilla.org/seamonkey/ident?i=nsIMailboxUrl
http://lxr.mozilla.org/seamonkey/ident?i=nsINetlibURL
http://lxr.mozilla.org/seamonkey/ident?i=nsIMsgUriUrl
Updated•25 years ago
|
Status: NEW → ASSIGNED
Comment 1•25 years ago
|
||
lxr does a horrible job of parsing c++. upgrading to the new
version when its done should fix this problem.
Comment 2•24 years ago
|
||
This bug has not been touched for more than nine months. In most cases, that
means it has "slipped through the net". Please could the owner take a moment to
add a comment to the bug with current status, and/or close it.
Thank you :-)
Gerv
yes this isn't a good solution, but there are other patches lying around my
tree that will help more...
Comment 5•22 years ago
|
||
so pick them off your tree !
now this patch hasnt been touched for a year ...
Attachment #35934 -
Flags: review?(john)
Attachment #35934 -
Flags: review?(john)
Attachment #35934 -
Attachment is obsolete: true
Comment on attachment 136550 [details] [diff] [review]
$, magic in the correct spot
http://landfill.mozilla.org/mxr-test/seamonkey/ident?i=nsMailboxUrl
Attachment #136550 -
Flags: review?(kiko)
Comment 8•21 years ago
|
||
Comment on attachment 136550 [details] [diff] [review]
$, magic in the correct spot
>Index: ident
>- &fileref("$fileidx{$fnum}, line $line",
>+ &fileref("$fileidx{$fnum}",
>+ "/$fileidx{$fnum}", $line)
>+ .", line ".
>+ &fileref($line,
> "/$fileidx{$fnum}",
This change makes usability worse, not better: it confuses us as to what link
we should click (and makes us try and guess if the links are the same or not,
which they are!).
One alternative, which is linking the actual file by the name and the specific
line with the line number as label, isn't better either, so I'm left without a
suggestion to make.
> } elsif ($t eq 'C') {
>+ local $,;
> print(", inheriting <ul>\n");
> foreach (@clss) {
>+ if ($,) {
>+ print $,;
>+ } else {
>+ $,=',';
>+ }
> print("<li>");
> if ($xref{$_}) {
>- print(&idref("class $_", $clss[0]));
>+ print("class ".&idref($_, $_));
> } else {
>- print("class $_");
>+ print("class <A TITLE='unindexed fixme'>$_</A>");
> }
> }
> print("</ul>");
I realize this isn't entirely your code, but can you find a way to rewrite this
to use a join() and avoid the need for the evil "$,"? Maybe push the items into
a perl list and then join it at the end?
I would rather use a <span> instead of an <a> (and I can't see why you're using
an uppercase A here). I suggest using "Field unindexed: see bug XXX for
details" if there's a bug open on this issue.
>@@ -139,6 +148,7 @@
> ."&root=/cvsroot\">change log</a> or Blame "
> ."<a href=\"" . $Conf->bonsaihome . "/cvsblame.cgi?&file=/mozilla/"
> .$fnam
>+."&mark=".@fpos
> ."&root=/cvsroot\">"
> ."annotations</a>"
> ."\n"
Hmm, what is this supposed to do? In your example I was taken to
http://bonsai.mozilla.org/cvsblame.cgi?&file=/mozilla/mailnews/local/src/nsMail
boxUrl.cpp&mark=37&root=/cvsroot
which has a green line marking
37 * ***** END LICENSE BLOCK ***** */
what for? Did you mean to mark the line it's referenced? Or did you mean to use
multiple marks? If you meant multiple marks, you need to use join here too.
Attachment #136550 -
Flags: review?(kiko) → review-
*** Bug 344643 has been marked as a duplicate of this bug. ***
Updated•18 years ago
|
QA Contact: lxr
Comment 10•8 years ago
|
||
MXR has been retired.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Updated•5 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•