Closed
Bug 5635
Opened 26 years ago
Closed 26 years ago
Find dialog size doesn't fit its content.
Categories
(Core :: Layout, defect, P3)
Tracking
()
VERIFIED
FIXED
M8
People
(Reporter: slogan, Assigned: law)
Details
Start viewer, go to Edit->Find In Page, bring it up. Size of window is bigger
than it needs to be, with significant extra whitespace to the right and below
the controls.
This may be x-platform, not just Unix.
Please take a look and see if it's a quick kill. If it turns into a layout
issue, let me know.
Updated•26 years ago
|
Assignee: kostello → sfraser
Target Milestone: M6
Comment 2•26 years ago
|
||
Assigning to Simon Fraser, setting milestone to M6.
Updated•26 years ago
|
Status: NEW → ASSIGNED
Updated•26 years ago
|
Target Milestone: M6 → M7
Comment 3•26 years ago
|
||
Dialogs just aren't there yet. M7
Updated•26 years ago
|
Target Milestone: M7 → M8
Comment 4•26 years ago
|
||
Sizing windows isn't happening yet (I can't find the bug).
Comment 5•26 years ago
|
||
This issue still occurs in the Linux June 30th build. (1999063008)
Updated•26 years ago
|
Target Milestone: M8 → M9
Assignee: sfraser → law
Status: ASSIGNED → NEW
Target Milestone: M9 → M8
Changing target milestone to M8 and reassigning to me. I have a fix:
Index: resources/finddialog.js
===================================================================
RCS file: /cvsroot/mozilla/xpfe/components/find/resources/finddialog.js,v
retrieving revision 1.2
diff -r1.2 finddialog.js
153c153
< ok();
---
> find();
Index: resources/finddialog.xul
===================================================================
RCS file: /cvsroot/mozilla/xpfe/components/find/resources/finddialog.xul,v
retrieving revision 1.8
diff -r1.8 finddialog.xul
6c6
< <window width="400" height="200" xmlns:html="http://www.w3.org/TR/REC-html40"
---
> <window xmlns:html="http://www.w3.org/TR/REC-html40"
7a8
> style="padding:5px;"
cvs server: Diffing src
Index: src/nsFindComponent.cpp
===================================================================
RCS file: /cvsroot/mozilla/xpfe/components/find/src/nsFindComponent.cpp,v
retrieving revision 1.27
diff -r1.27 nsFindComponent.cpp
660,667c660,667
< rv = GetAppShell()->CreateTopLevelWindow( nsnull,
< url,
< PR_TRUE,
< getter_AddRefs(newWindow),
< nsnull,
< dialog,
< 0,
< 0 );
---
> rv = GetAppShell()->CreateDialogWindow( nsnull,
> url,
> PR_TRUE,
> getter_AddRefs(newWindow),
> nsnull,
> dialog,
> NS_SIZETOCONTENT,
> NS_SIZETOCONTENT );
This has been reviewed by Dave Hyatt. I will submit it for approval and will
check it in later today when granted.
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Updated•26 years ago
|
Status: RESOLVED → VERIFIED
Comment 7•26 years ago
|
||
Fixed in the July 14th Linux build (1999071416)
You need to log in
before you can comment on or make changes to this bug.
Description
•