HTML checkboxes and radiobuttons used to change color onmousedown (:hover:active). In my latest win98 trunk build, this is no longer the case. Ian, wanna check this out?

works for me on win2k trunk... are you sure your colours aren't horked? Or maybe it's because :hover is undergoing some major surgery at the moment?

Yes, I still see this in a brand new downloaded trunk build on win98 after deleting profile/moz*.dat/all traces of mozilla...

Still seeing this in nightlies and builds after months of new profiles, still very annoying. Maybe some rules got lost in the move to forms.css?

blake: Ok, this is _still_ WORKSFORME. Could you give me an exact testcase including steps to reproduce? Thanks...

Step 1: Mousedown on a checkbox or a radiobutton.

QA Contact Update

I did the nasty for you guys (adding testcase) to show that :active does work for checkboxes and radiobuttons. Blake is it that you expect mozilla to render :active like it used to (with an outline focus)? I am guess that you are also trying to report that the :active and :focus rules should changed? I know that I hate the existing border-style:groove crappy rule that changed about the time you reported this to take out the outline (the way IE renders it). I wish I could think of a better way to render this without using groove to show :active and/or :focus. It just looks soooooo odd.

THe test case checkboxes change color on mousedown, but the ones in bugzilla below this textarea dont...

yes, that was because someone changed the rendering of the :active state waaaaaaaaaaaaayyyyyyyyyyyyyy back over a year ago so it no longer creates an outline for checkboxes and/or radio form controls during the :active state. in my testcase, I changed the background-color to show that the :active DOES work for the checkbox and radio form control. if this report is about the :active psuedo not working for a checkbox and/or radio control than this should be marked WFM. however, this report might really be about getting rid of the bug-eyed look of the :active state of a checkbox &/or radio control to look more like IE. I am not sure and I think Ian wasn't sure either... Blake your thoughts?

Reproduced on build 2001062105, Mac OS 9.1. (Mot that I should be seeing these bletcherous Windows-like form controls on Mac OS, but that's a different bug.) > if this report is about ... however, this report might really be about ... This bug has absolutely nothing to do with outlines. What part of `change color onmousedown' didn't you understand, exactly? :-) Try mousing down on a checkbox or radio button in a native Windows app, and see it change color.

ok, after rereading this bug report a few times and testing moz by changing my system colors, I think the "fix" for this bug should be very simple. For input[type=radio] and input[type=checkbox], mozilla uses: background-color: -moz-Field; which in default windows appearance setting is white For input[type="checkbox"]:hover:active and input[type="radio"]:hover:active, moz uses: background-color: ThreeDHighlight; which in default windows appearance setting is also white!! On windows, if you try changing your ui appearance via "Control Panel"->"Display Properties"->Appearance->Scheme to ... "High Contrast Black" as an example you will find that it actually changes color. So a "fix" for this would be to change the system colors to use something else. For example rather than using ThreeDHighlight, maybe we should use Highlight or ThreeDFace (I think windows uses ThreeDFace, not sure about Mac and Gnome/GTK)? Just a thought. Okay, I can't stand using this ugly "High Contrast Black" scheme anymore, I'm posting and restarting moz.

Ian, don't laugh at my patch ignorance (how do you make those patches?) but this is what I would suggest in addition to background-color to make mozilla function like other programs with regard to radio/checkboxes: In forms.css (lines 299-318 as of win build 7-24-03) - input[type="checkbox"]:focus, - input[type="radio"]:focus { - border-style: groove; - } - - input[type="checkbox"]:hover:active, - input[type="radio"]:hover:active { - border-style: inset; - background-color: ThreeDHighlight; + input[type="checkbox"]:active, + input[type="radio"]:active { + background-color: ThreeDFace; I propose ditching the :focus groove rule (mozilla has to be the only program that uses it with radio/check controls). Also, I do not think that the :hover is necessary for the :active rule because mozilla no longer has :hover rules for form controls. I also think that _basic@yahoo is correct about the correct gui bgcolor is ThreeDFace. I will test this in linux as well. This should be an easy, painless fix. Comments?

You have to indicate focus somehow...

Why? Looking at native window radio & checkboxes in linux and windows I do not see any :focus. Konquerer in kde does not. What does nav4.x or opera do? IE is the only program I could find that does an outline border for :focus. I think we did this in the past (please no more bitch slaps (mpt))? Personally, I think this looks so much better and normal than the groove :focus rule. BTW: my changes to the forms.css in linux make it look/work like native radio/chaeckboxes aswell. :-)

James a diff is created using a diff program or a cvs program. If you have trouble creating a diff, post the whole forms.css file here. Its not too big.

James file a new bug for you other changes. I think we need to discuss this more, but this bug is not the right place.

Is there any benefit (performance, etc) in changing the input[type="radio"]:hover:active to just input[type="radio"]:active for the rule? To me it would make the rule matching easier for mozilla and there are no negative impacts because there are no other :hover checkbox/radio rules. Also per _basic@yahoo.com comments, filed removing groove borders from checkboxes and radio controls (bug 92286).

James that too belongs in another bug if it is valid, I would recommend going to the netscape.public.mozilla.style newsgroup to discuss that first

Blake can you review the patch (from 07/25/01 10:54)? It is simple and helps polish mozilla a little more. :-)

> Is there any benefit (performance, etc) in changing the > input[type="radio"]:hover:active to just input[type="radio"]:active for the > rule? That would be incorrect. On all platforms I've used, mousing off a widget (radio button, checkbox, button, menu item, whatever) and releasing the button does not activate the widget. To indicate this, the widget returns to its mouseup appearance when the cursor is not over it. That's what the `:hover' bit is for -- checking that the cursor is over the widget. The patch looks fine to me, but I haven't considered myself capable of giving r= before and I'm not about to start now.

r=bryner

Comment on attachment 43536 [details] [diff] [review] change to ThreeDFace from ThreeDHighlight sr=attinasi

fixed

verified fixed in win2k build id :- 2002-03-11-11trunk build