Closed
Bug 5663
Opened 25 years ago
Closed 25 years ago
Copy and paste of entities does not work.
Categories
(Core :: DOM: Editor, defect, P3)
Core
DOM: Editor
Tracking
()
VERIFIED
FIXED
M6
People
(Reporter: sujay, Assigned: buster)
Details
using 4/28 build of apprunner on all platforms:
when content is found to contain the <
and > markup characters. These codes are written out as character entities. This
means that they no longer get interpreted in the XIF as XML markup.
Updated•25 years ago
|
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → WONTFIX
Comment 1•25 years ago
|
||
This is by design. All '<' and '>" characters that are in the content model are
required to be output as < and > respectively.
Please let me know if you had something else in mind.
Comment 2•25 years ago
|
||
But when the user types "<", shouldn't we be putting "<" into the content?
I'm pretty sure we don't do this now.
Updated•25 years ago
|
Status: RESOLVED → REOPENED
Updated•25 years ago
|
Resolution: WONTFIX → ---
Comment 3•25 years ago
|
||
Greg, I'm reopening simply because I don't want this to disappear without getting
a good answer ;-)
Updated•25 years ago
|
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Comment 4•25 years ago
|
||
Working as advertised. Double checked with Simon.
Greg, when did this fix go in? I just tried to verify it on the 5/6 build.
I now see different results. When I cut/copy some text with "<" and ">"
in the string and then paste it, I see the symbols "y" with umlauts.
It doens't look fixed in the 5/6 build.
I'm re-opening this one, kick it back to me if your fix intended
to go in for the 5/7 build...
Updated•25 years ago
|
Resolution: FIXED → ---
Summary: we're not handling entities in editor → Copy and paste of entities does not work.
Comment 6•25 years ago
|
||
Adjusted summary, removed resolution.
Comment 7•25 years ago
|
||
cc: akk.
Comment 8•25 years ago
|
||
cc: akk.
Updated•25 years ago
|
Assignee: kostello → akkana
Status: REOPENED → NEW
Comment 9•25 years ago
|
||
I'll take this. We should be able to handle pasting of those characters, and
right now we seem to be ignoring them in a plaintext paste.
Updated•25 years ago
|
Target Milestone: M7
Comment 10•25 years ago
|
||
Marking M7, but I'm really hoping to get this fixed for M6.
Comment 11•25 years ago
|
||
One problem I'm seeing: I get into nsHTMLToTXTSinkStream::EncodeToBuffer and get
the assert: "The unicode encoder needs to be initialized". There's no encoder
because the charset equals ucs2 in InitEncoder, so it thinks it doesn't need an
encoder (but then in EncodeToBuffer it thinks it can't proceed without one).
EncodeToBuffer gets called with argument of "lt" and "gt" and it doesn't return
any encoding for these entities because of mEncoder being 0.
In nsHTMLToTXTSinkStream::AddLeaf(), if I add the following clause in front of
the EncodeToBuffer(text) call, entities start working again:
if (!mUnicodeEncoder)
{
char* str = text.ToNewCString();
EnsureBufferSize(text.Length()+1);
strcpy(mBuffer, str);
delete[] str;
}
else
I'll do some more investigating to find out whether this is really the right
place to fix this, and to test to make sure it doesn't break anything else, but
we should be able to get this fixed in the M6 timeframe (changing milestone
accordingly).
Status: NEW → ASSIGNED
Target Milestone: M7 → M6
Updated•25 years ago
|
Assignee: akkana → kostello
Status: ASSIGNED → NEW
Comment 12•25 years ago
|
||
Greg has approved my fix (which I moved into EncodeToBuffer since it seemed to
belong better there) and asked me to hand the bug off to him to find out why
mUnicodeEncoder isn't being initialized. But meanwhile, the symptom is fixed
and you should be able to copy entities now.
Reporter | ||
Comment 13•25 years ago
|
||
actually I'll wait till this one is marked RESOLVED-FIXED before
verifying...
Updated•25 years ago
|
Status: NEW → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Comment 14•25 years ago
|
||
Resolved-Fixed. Akkana's checkin fixes the problem.
Reporter | ||
Comment 15•25 years ago
|
||
verified in 5/19 build.
Comment 16•25 years ago
|
||
Reassigning all bugs Assigned To kostello to buster
Assignee | ||
Comment 17•25 years ago
|
||
All these bugs were marked "New" when Jan transfered ownership of them to me.
They were all resolved and need to be marked "Verified" again.
Comment 18•25 years ago
|
||
This was Verified on 05/19/99...resetting back to Verified...Bugzilla wacked
out.
You need to log in
before you can comment on or make changes to this bug.
Description
•