Closed
Bug 5734
Opened 26 years ago
Closed 26 years ago
After inserting a Image, selecting undo causes a crash.
Categories
(Core :: DOM: Editor, defect, P2)
Tracking
()
VERIFIED
FIXED
M5
People
(Reporter: chrispetersen, Assigned: akkzilla)
Details
Build: Apprunner
Version: April 29th Build. (1999042908)
Platform: All
Expected Results: The image (placeholder) to be removed.
What I got: The program crashes.
Steps to Reptroduce:
1) Launch Apprunner.
2) Select Editor from the Tasks menu.
3) From the Insert menu, select Image.
4) The image placeholder is inserted.
5) Select Undo from the File menu.
Reporter | ||
Updated•26 years ago
|
QA Contact: 4079 → 4144
Updated•26 years ago
|
Assignee: kostello → akkana
Target Milestone: M6
Comment 1•26 years ago
|
||
Changing assinment to Akkana, marking M6
Assignee | ||
Updated•26 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•26 years ago
|
||
This was working as of the code I checked in in version 1.17. In version 1.23,
for some reason cmanske reverted the InsertImage code back to the pre-1.17 code,
and that brought back the crash that 1.16 and 1.17 were meant to address (and
also made insert image stop working -- setting attributes on an image doesn't
work once the image is in the tree, you have to set the attributes on the node
before it's inserted into the tree).
We could fix InsertImage for M5 by putting back the version 1.17 code. Charley,
is there some reason not to do this?
Assignee | ||
Updated•26 years ago
|
Severity: normal → major
Priority: P3 → P2
Target Milestone: M6 → M5
Assignee | ||
Comment 3•26 years ago
|
||
Turns out just plugging in the InsertImage code from 1.17 makes it work, no
rewriting required. Moving back to M5 and begging for checkin approval ...
Comment 4•26 years ago
|
||
Sorry I messed this up. I was planning on converting to the new Insert Image
code I'm working on, but my back problem prevented me from completing this for
M5.
Go ahead and revert back to v1.17 for M5, then reassign this bug to me and I'll
finish my work in M6.
Assignee | ||
Updated•26 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Target Milestone: M5 → M6
Assignee | ||
Comment 5•26 years ago
|
||
Fixed for M5.
Assignee | ||
Updated•26 years ago
|
Target Milestone: M6 → M5
Reporter | ||
Updated•26 years ago
|
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 6•26 years ago
|
||
Fixed in the June 2 Build.
You need to log in
before you can comment on or make changes to this bug.
Description
•