I just lost about an hour of time with a broken build, becuase of this nasty hack of aliasing NGLayoutConfigInclude.h to MacConfigInclude.h. I happened to cancel the dist process half way, so failed to reach the last line where the old MacConfigInclude.h alias is replace by the NGLayoutConfigInclude.h one. We need to figure out: 1. If this hack is still needed 2. Why NGLayoutConfigInclude.h exists at all. It certainly violates the organization of config files that I started with. 3. Whether there are any commercial build implications in any of this.

I agree it is evil. I lost some time on it one day as well.

Putting on [PP] radar.

Mac specific issue. Reassigning to Don.

Waqar.. Can you look at this.. I don't understand much about this issue and you are closer to those who this effects.

Looking into it.

mass re-assign of all bugs where i was listed as the qa contact

This bug has been marked "future" because the original netscape engineer working on this is over-burdened. If you feel this is an error, that you or another known resource will be working on this bug,or if it blocks your work in some way -- please attach your concern to the bug for reconsideration.

FOrgot to set the milestone.

bulk reassigning Waqar's bugs to Don.

I did a cross reference on NGLayoutConfigInclude.h, and I do believe its not used anylonger. I found one reference that was commented out. I think this issue was cleared up.

This is not the case. See <http://lxr.mozilla.org/mozilla/source/build/mac/build_scripts/ MozillaBuildList.pm#520>

Simon.. I think you should handle this.. I dont know very much about the Mac build system build scripts.

Taking. Patch removes NGLayoutConfigInclude.h. Everything still builds, MOZ_NGLAYOUT was removed a while ago ;-). I also checked for the include and MOZ_NGLAYOUT by searching my tree and by using http://lxr.mozilla.org/mozilla/. Looking for sr from Simon (patch includes commercial files).

Comment on attachment 71114 [details] [diff] [review] Remove NGLayoutConfigInclude.h Thank you Thank you Thank you. sr=sfraser

Comment on attachment 71114 [details] [diff] [review] Remove NGLayoutConfigInclude.h a=dbaron for trunk checkin

Checked in.