Closed Bug 5806 Opened 25 years ago Closed 25 years ago

MLK: the editor is leaked.

Categories

(Core :: DOM: Editor, defect, P3)

Product:
Core
Component:
DOM: Editor
Platform:
All
Mac System 8.5
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: sfraser_bugs, Assigned: sfraser_bugs)

References

(
URL
)

Details

We currently don't dispose of the editor app core on closing an editor window. This is bad, since it holds a bunch of references to other things.
Hardware: Macintosh → All
Target Milestone: M5
Status: NEW → ASSIGNED
Target Milestone: M5 → M6
It seems that there are a number of problems preventing this from working right now. The onunload handler in XUL doesn't seem to get called, so I don't have a chance to remove the editor app core from the app cores manager's list. M6
Target Milestone: M6 → M7
This depends on the onunload bugs being fixed. M7
URL: http://bugzilla.mozilla.org/buglist.c...
Summary: MLK: the editor app core is leaked. → MLK: the editor core is leaked.
Changed to the editor is leaked. See also the bugs in the URL.
OK, so the refCount of the editor when the editor appcore goes away is 5. A whole bunch of things (notably event listeners) are holding on to editor references, and my guess is that they shouldn't be.
Summary: MLK: the editor core is leaked. → MLK: the editor is leaked.
Fix summary.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Fixed. There were a bunch of probs here, including 2 cases of circular ref counts. Should all be fixed (for the moment).
Status: RESOLVED → VERIFIED
verified in 6/1 build.
Sujay, can I ask how you verified this? It would be good to have a way to test for leakage in case this problem shows up again.
Status: VERIFIED → REOPENED
Oops, this one was accidentally marked VERIFIED-FIXED...I thought this was some other bug...I'm re-opening.... its a low level issue, I have no way to verify this one...
Resolution: FIXED → ---
Clearing Fixed resolution.
Blocks: 7217
Blocks: 7218
Depends on: 8248
Blocks: 7210
looks like fixed should remain.. verification needs to be worked on
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
need help verifying this bug....anyone? thanks! please mark verified-fixed.
Whiteboard: Need to verify if 8248 is fixed, and if that fixes this.
Status: RESOLVED → REOPENED
No longer depends on: 8248
This bug is not fixed, and I have removed the dependency on 8248, which is fixed.
Resolution: FIXED → ---
Whiteboard: Need to verify if 8248 is fixed, and if that fixes this.
I've debugged this to death, and as far as I can see, the XPConnect-wrapped objects are still not being garbage collected. I need to debug this with jband. If this really is a problem, then this bug is pretty serious, and should stay on M7. I've left voicemail for jband.
Whiteboard: There is serious leakage all over.
Preliminary investigation shows that wehshells and webshellwindows are also being leaked. This should certainly stay on M7.
Whiteboard: There is serious leakage all over. → Investigating -> There is serious leakage all over.
Target Milestone: M7 → M8
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
I verified in the debugger that the editor is deleted when closing an editor window.
Simon, does that mean we can mark this bug VERIFIED-FIXED? The comments in the whiteboard(serious leakage) lead me to believe that the bug needs to be re-opened?
Whiteboard: Investigating -> There is serious leakage all over.
Cleaned whiteboard. This can be marked verified.
Status: RESOLVED → VERIFIED
marking verified fixed...
You need to log in before you can comment on or make changes to this bug.