go to a page where there is nothing to prefill (eg, netscape.com) click "Prefill Form" on the form toolbar expected: - should be disabled since we know there is nothing to prefill actual: - dialog that pops up saying "nothing to prefil" UI should prevent users from doing things that aren't applicable, not put up error dialogs after they do it.

this should be amended to not show the toolbar at all if there isn't anything to prefill.

Yes, unfortunately I know about this. The code originally checked in for bug 23095 had this working correctly. But it also caused leak and bloat to occur. So I immediately commented out the call that would disable this button. See my comments in that other bug report. This needs more work to get it working correctly without leaking. Since the other bug report is now marked fixed, it's a good thing you opened this bug report so we can track this existing problem.

Well, it does have a Save Form Data button, so just hiding it when there's nothing to prefill doesn't make all that much sense...?

Terri wasn't asking to hide the whole menu -- just disable the one button. I agree with her.

Sorry, it was Mike Pinkerton who reported this, hot Terri. Terri just reported a similar bug so I got confused.

1/4 15:23 -- "this should be amended to not show the toolbar at all if there isn't anything to prefill."

No, there could be something to save. The expected behavior should be as follows: 1. If no form, then hide the entire toolbar 2. If none of the fields on the form have a saved value, then disable prefill button 3. If none of the fields on the form have any data entered into them, then disable save button. Item 1 is currently working. Item 2 was implemented but backed out because of the bloat problem described in bug 23095. This is the topic of this bug report. Item 3 has not yet been implemented because it involves getting notification on every character typed. It is the topic of bug 64357 which Terri reported (and is why I confused Terri with Mike in my comment above).

How about if items 2 and 3 are both true? I think the toolbar should also be hidden in that case (I'll split this off, if you want). I know it also a View button, but we shouldn't keep this toolbar open just for one button, especially when it won't be used very much.

I thought about not having the toolbar if both buttons are disabled, but decided it's probably good to have it. It lets the user know that we can prefill forms. In particular, he might get the idea to press the view button and discover that he can pre-enter his data for the form. However, I don't feel that strongly about it and could be convinced to do as you say. The only problem is then the new bug would be blocked by both this bug and bug 64357.

nav triage team: Since we've decided to take out this feature, its not a beta stopper.

Fix checked in. The code to turn off the "prefill" button is there but, alas, it has been commented out. The code for this is part of the patch that is in bug 31967

Verified