Closed Bug 6496 Opened 25 years ago Closed 25 years ago

[PP]Select Message|Mark|As Read crashes my system

Categories

(MailNews Core :: Backend, defect, P3)

PowerPC
Mac System 8.5
defect

Tracking

(Not tracked)

CLOSED FIXED

People

(Reporter: fenella, Assigned: scottputterman)

Details

Re: Mac (1999-5-14-08 m6) steps: 1. Open Messenger from Tasks 2. Close the message center 3. Select a Unread message from the Inbox folder. (Unlike Win and linux, message does not change to Read here, refer to bug 6485) 4. Select Message|Mark|As Read, system crashes here, I have to do a reboot. Second scenario: 1. Select a Read message 2. Select Message|Mark|As Read, system also crashes, I have to do a reboot. This occurs on the Mac only
cc: ducarroz since this is on Mac only cc: putterman since this is marking as read feature.
You can assign Marking Read bugs to me. If someone with a Mac can give me a call stack, I could look into this. This will probably get looked at on Monday. Since there's no crash with reading a message, this isn't a smoketest stopped.
works fine for me with a full rebuild of this afternoon at 5 pm.
I reproduced this crash on a different Mac than Fenella's. The talkback tracking ID is ENT44RMN. The incident ID is 8559478 Call Stack: (Signature = mailnews.shlb + 0x1b8b4 (0x0b5e3e24) 435b49f7) mailnews.shlb + 0x1b8b4 (0x0b5e3e24) mailnews.shlb + 0x5b3c (0x0b5ce0ac) mailnews.shlb + 0x1cd8 (0x0b5ca248) js_Invoke() [jsinterp.c, line 649] js_Interpret() [jsinterp.c, line 2197] js_Invoke() [jsinterp.c, line 666] js_Interpret() [jsinterp.c, line 2197]
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → DUPLICATE
Target Milestone: M6
The problem is due by the fact that when you ask for the database property of a tree widget from JS doesn't work anymore. Scott, you should modify your code to check if db == nsnull before using it. Any action performe from the menu on a message thread will failed or crash. This problem has been already reported as bug 6106 (http:// bugzilla.mozilla.org/show_bug.cgi?id=6106) *** This bug has been marked as a duplicate of 6106 ***
Status: RESOLVED → REOPENED
Status: REOPENED → ASSIGNED
I'm reopening this bug since I need to go back and bulletproof all of our js functions so when this happens we don't crash.
Resolution: DUPLICATE → ---
Status: ASSIGNED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
I checked in a fix for this. Now the msgappcore functions we call through js won't crash if null is passed in. Null being passed in would be wrong, so the functionality won't work and would most likely require another bug. However, at least we won't crash. If Chris's fix works, you won't be able to test this by seeing if it no longer crashes. One way to test it would be to get one of our js files, for example in this case, widgetglue.js. Look for the function called MsgMarkMsgAsRead and change the line appCore.MarkMessagesRead(tree.database, messageList, markRead); to appCore.MarkMessagesRead(null, messageList, markRead); If it doesn't crash then this is fixed. It won't mark the messages read since null is an invalid parameter.
QA Contact: 4080 → 4104
Status: RESOLVED → VERIFIED
RE: Mac build (1999-05-17-09 m6) Both Mark|As Read and Mark|As Unread work fine.
Blocks: 10597
Why does 10597 depend on this bug?
No longer blocks: 10597
Status: VERIFIED → CLOSED
My mistake, dependency removed
My mistake, dependency removed
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.