Closed Bug 6583 Opened 25 years ago Closed 25 years ago

Disabled buttons should use flat gray text instead of 3D text

Categories

(Core :: XUL, defect, P4)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: sfraser_bugs, Assigned: eric)

References

Details

Currently, the text of disabled toolbar buttons is drawn with a fake 3D effect. This makes the buttons look enabled compared to the text labels of normal buttons, so is deceiving. The text of disabled buttons should be drawn gray (in the Mozilla skin), or some less saturated version of the normal enabled text color.
Assignee: trudelle → pinkerton
Priority: P3 → P4
Target Milestone: M10
reassigning to pinkerton as p4 for m10
Status: NEW → ASSIGNED
Target Milestone: M10 → M15
moving to m15
Assignee: pinkerton → german
Status: ASSIGNED → NEW
Target Milestone: M15
Actually, this is a bug for German, since the widget spec shows it this way. German, why is it that disabled things have 3D labels, whereas enabled things don't? For most people, 3D looks more 'touchable' than flat, so this seems wrong.
Status: NEW → ASSIGNED
Target Milestone: M10
moved to M10. Q: who is the owner of drawing algorithms behind the current disabled look? Note: on windows the groove look == disabled. But I agree perceptually this could be improved to make the disabled state less salient.
Target Milestone: M10 → M11
m11. let me know if we can get this going in the next couple of days.
They would look much better if disabled button text matched the way disabled menu items are draw.
Assignee: german → evaughan
Status: ASSIGNED → NEW
Disabled toolbar button text is being displayed Windows-style (http://msdn.microsoft.com/library/books/winguide/PLATFRM2/D5/S11863.HTM), but disabled menu items are being shown MacOS-style (http://www.mozillazine.org/screenshots/screens/1999093012.nav.context.gif). -- mpt
OS: Mac System 8.5 → All
Summary: 3D text on disabled buttons looks wrong → Disabled buttons should use flat gray text instead of 3D text
This looks really bad for disabled buttons that have white text. We use white text on buttons in the new skin. The new skin is landing very soon and it would help quite a bit to get this changed.
Blocks: 16395
Actually the only acceptable behavior is that the css file should decide what the disabled look for the text is. That means I want to set color:#blah for titledbutton[disabled="true"]. the text color should not be hardcoded at all as only the skin designer can decide what works best in the context of his/her skin.
No longer blocks: 16395
Blocks: 16395
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Ok this is fixed. There is no hard coded inset. The text color is whatever you set it to be.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.