Build: 5/17/99 SeaMonkey build 1. Use jar at http://jimbob/jars/a_addsubcomp_1.jar 2. Using the form Install.AddSubcomponent(jarSrc); 3. Trigger jar RESULT: The component, 'smrtupdt.txt', is not added to 'Program' folder. The log shows that the script aborts. I was not able to determine why the installscript aborts. Install.log shows: --------------------------------------------------------------------------- Acceptance: a_addsubcomp_1 --------------------------------------------------------------------------- Starting Installation at 05/17/1999 14:48:32 Aborted Installation at 05/17/1999 14:48:33 Finished Installation 05/17/1999 14:48:33 EXPECTED RESULT: The component, 'smrtupdt.txt', is added to the 'Program' directory. The Install.log shows that the component was added successfully.

Changing QA Contact from Grace to Jimmy.

The abort is from: if (0 == Install.GetLastError()) Install.FinalizeInstall(); else Install.AbortInstall(); The error is -208. It is a bug in the overloading. Assigning to ssu.

The fail thru is deliberate because I didn't know what default value to set the folder variable to. I talked to Dan and he told me that it should retrieve an internal variable that is set by the user calling SetPackageFolder(), but that it has not been implemented yet. I've filed a new bug on SetPackageFolder(): http://bugzilla.mozilla.org/show_bug.cgi?id=6719

fixed. Look for it in the next build.

Build 6/8/99 Windows I have added the SetPackageFolder() call. When using the form (http://jimbob/jars/a_addsubcomp_1.jar): f = Install.GetFolder("Program"); Install.SetPackageFolder(f); Install.AddSubcomponent(jarSrc); the installscript completes, but there is no file installed unlike what the Install.log indicates. However, if I trigger a similar jar using the form (http://jimbob/jars/a_addsubcomp_1_subdir.jar): f = Install.GetFolder("Program", "a_addsubcomp_1_subdir"); Install.SetPackageFolder(f); Install.AddSubcomponent(jarSrc); then a component, a_addsubcomp_1_subdir, is added to the Program target directory. "a_addsubcomp_1_subdir" is expected to be the subdirectory. It turns out that the jarSource, "smrtupdt.txt", instead got named "a_addsubcomp_1_subdir". I did try two other forms of AddSubcomponent (http://jimbob/jars/f_addsubcomp_full_setpkgfldr.jar and http://jimbob/jars/f_addsubcomp_4_setpkgfldr.jar) to see if there was any difference. Both jars behaved as expected, so I conclude that this problem is isolated to just the one form, AddSubcomponent(String jarSource).

The problem with the single parameter AddSubcomponent() was that it was not defaulting the target file name to the source file name. It was actually defaulting to an empty string (""). It is now fixed to use the source file name by default. Look for it in the next build.

Build 6/14/99 Looks great!

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall Engine