task: need to XPIDL'ize editor

files that are changed. as well as some additions to the idl directory that aer allready checked in M base/ChangeAttributeTxn.cpp M base/ChangeAttributeTxn.h M base/CreateElementTxn.cpp M base/CreateElementTxn.h M base/IMETextTxn.cpp M base/IMETextTxn.h M base/InsertTextTxn.cpp M base/InsertTextTxn.h M base/TextEditorTest.cpp M base/nsAOLCiter.cpp M base/nsAOLCiter.h M base/nsComposerCommands.cpp M base/nsEditor.cpp M base/nsEditor.h M base/nsEditorCommands.cpp M base/nsEditorEventListeners.cpp M base/nsEditorShell.cpp M base/nsHTMLDataTransfer.cpp M base/nsHTMLEditRules.cpp M base/nsHTMLEditRules.h M base/nsHTMLEditor.cpp M base/nsHTMLEditor.h M base/nsHTMLEditorLog.cpp M base/nsHTMLEditorLog.h M base/nsHTMLEditorStyle.cpp M base/nsIHTMLEditRules.h M base/nsInternetCiter.cpp M base/nsInternetCiter.h M base/nsPlaintextDataTransfer.cpp M base/nsPlaintextEditor.cpp M base/nsPlaintextEditor.h M base/nsTableEditor.cpp M base/nsTextEditRules.cpp M base/nsTextEditRules.h M base/nsWrapUtils.cpp M base/nsWrapUtils.h M idl/makefile.win M idl/nsIPlaintextEditor.idl M public/makefile.win M public/nsIEditorMailSupport.h M public/nsIEditorStyleSheets.h M txtsvc/src/nsTSDNotifier.cpp M txtsvc/src/nsTSDNotifier.h M txtsvc/src/nsTextServicesDocument.cpp

I just attached 2 updated diffs for mozilla/layout - fixes build problem in nsGfxTextControlFrame2.cpp and mozilla/editor - fixes a couple of crashers I ran across (during paste and style changes) and the color picker swatch updating problem.

I just attatched an updated mozilla/editor diff that fixes password fields and list type (bullet to number, and vice versa) toggling. Things are working well now, and I've been able to use it all day without noticing any problems that don't already exist on the trunk. The list of patches is getting confusing so let me list which ones you actually need from the list above: 03/27/01 17:00 diff for domidl file 03/27/01 17:32 mozilla\embedding\browser\activex\src\control\ 1 file 03/29/01 15:02 Updated mozilla/layout diffs 03/30/01 15:06 Updated mozilla/editor diff (fixes password fields, list toggling)

r=jf due to serious doomage i only reviewed the editor/base changes, and only in files that are well known to me. notes: i'm surprised there is not EqualsIgnoreCase(), EqualsWithConversion(), etc, that takes an nsReadableString. Should we file a bug against this with scc? i take it the nsString tString(*inString); // CRAPCRAP lines are to get a unified buffer, so that tString.GetUnicode() can be called? Should there be an api addition to nsReadableString that will hand you a unified buffer, building one of needed? scc again? kin, mike, has either of you tested ime to make sure it still works? in nsHTMLEditorStyle.cpp, tPassString is added in one routine, but does not seem needed. Mike, please double check this and either remove it or do what you meant to do with it. in nsTextEditRules.cpp, is there a reason why you wrote nsNormalizeCRLF, but then don't actually use it in WillInsertText()? We are going to have to work on {nsTextEditRules/nsHTMLEditRules}::WillInsertText(). The extra string copy is going to slow things down. simon, i need you to do the mac build support here.

the crap crap things WERE for when i can get a real place to call these compare ect function that USED to be on nsString and now we only have the nsAReadable/writable interfaces. once we went in i was going to then replace all of those with the properly sancioned replacements. the normalizecrlf was put in because i started to write these helper class/funcs myself only to realize how many I would have to write and that we realy needed a place in xpcom or whatever to do this. i can remove it from the file before i check it in since its not used. as to the other variable thats not used i will talk to you about that when you get in.

POST string changes for editor with modifications from peoples suggestions.

It looks like nsIEditorStyleSheets.h got removed from Makefile.in but not makefile.win; ditto with nsITableEditor.

Is there anything in the first attachment that isn't in the later attachments? I'm confused. It would be easiest if we either had i) one big patch ii) a patch for each top-level dir that was touched

ok last patch is all you need now. it has layout,embed, editor and all. had some issues with nsPromiseFlatString that we worked around(scc has fixed those but not in tree yet but it doesnt matter for this last patch). sorry for the patch spam but we had some landings that needed to be updated.

checked in finally...

verified in 4/9 build.