I would like someone to change the color.cpp program. The Photon GUI prefers he same RGB ordering as Windows does, but still has to define XP_UNIX. I can think of several ways to do this "ifdef" but diff I provided is one of the simpler. This "patch" points out a small flaw since NTO can support both the Photon GUI and the GTK GUI so if we ever go back and try to support the GTK GUI someone will have to change this again to make the RGB ordering decision based on the GUI instead of the platform. <this should be an attachment> Index: color.cpp =================================================================== RCS file: /cvsroot/mozilla/modules/libimg/src/color.cpp,v retrieving revision 3.8 diff -u -r3.8 color.cpp --- color.cpp 1999/04/15 03:04:04 3.8 +++ color.cpp 1999/05/18 11:53:36 @@ -505,7 +505,7 @@ if (!mask) { while (sp < end) { -#if !defined(XP_UNIX) +#if !defined(XP_UNIX) || defined(NTO) out[2] = sp[0]; out[1] = sp[1]; out[0] = sp[2]; @@ -521,7 +521,7 @@ while (sp < end) { if (*mask++) { -#if !defined(XP_UNIX) +#if !defined(XP_UNIX) || defined(NTO) out[2] = sp[0]; out[1] = sp[1]; out[0] = sp[2];

JK: Quick question: Where will NTO be defined? Most platform related defines are in mozilla/include/xp_core.h.............. -pn

I checked the patch in and tested it.

much thanks, Jerry. Can I call on you for testing when I rewrite this stuff for crossplatform? -pn

Unfortunately, verifying this is quite over my head. Pam, coud I please confirm as a formality that you've reviewed Jerry's check-in and confirm that it's all to your satisfaction? Thanks!

Its checked in. -pn