Closed Bug 6674 Opened 26 years ago Closed 25 years ago

{css1} overflow rules confused by tables

Categories

(Core :: Layout: Tables, defect, P2)

x86
Windows 98
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: ian, Assigned: karnaze)

References

()

Details

(Keywords: css1, Whiteboard: [TESTCASE] erin@imaginet.com)

Attachments

(3 files)

For some reason, overflow inside a table is clipped. For example, the text in the following table: <table> <tr> <td> <div style="width:80px;"> Truncated?&nbsp;It&nbsp;should&nbsp;not&nbsp;be! </div> </td> </tr> </table> ...is truncated after the "It". This should not happen, and in fact it doesn't, if you take the table out. See the following test case: http://www.bath.ac.uk/%7Epy8ieh/internet/projects/mozilla/tableoverflow.html
See also bug 5999.
Assignee: karnaze → kipp
Kipp, can you take a look. nsTableCellFrame::Reflow makes a call to ReflowChild on its area frame and it is returning 80px as its desired size.
Target Milestone: M15
[Kipp is on sabatical.]
Status: NEW → ASSIGNED
Priority: P3 → P2
Target Milestone: M15 → M9
Assignee: kipp → karnaze
Status: ASSIGNED → NEW
The problem is that the table cell frame painting code is ignoring the css "overflow" property. In particular, what the cell code does is *always* sets a clip so that things in the cell can't paint outside. The fix is to do what the block code does: Test the value of the mOverflow property and if its value is "NS_STYLE_OVERFLOW_HIDDEN" then and only then set the clip. I could make the change, but I'd probably break some nasty navigator compatibility thing. So I'm reassigning it to karnaze to answer the compatability question so that he can either nod or frown....I'll even be glad to make the fix if he wants...
Whiteboard: makingtest erin@imaginet.com
Attached file test case for 6674 (deleted) —
Attached file new test case (deleted) —
Whiteboard: makingtest erin@imaginet.com → [TESTCASE] erin@imaginet.com
how the browser reads tables and CSS together needs to be fixed
Status: NEW → ASSIGNED
Kipp, I would appreciate it if you could fix this. Pushing/poping the rendering context state and setting the clip rect was done to make collapsing row/row groups work.
Assignee: karnaze → kipp
Status: ASSIGNED → NEW
Reassigning to Kipp, based on earlier comments.
Target Milestone: M9 → M10
Moving to M10.
Status: NEW → ASSIGNED
s/with/without/ in that previous comment. Urk.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Fixed. The table cell rendering code now honors the css overflow property.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: kipp → karnaze
Status: REOPENED → NEW
I'm going to accept the bug and back out Kipp's changes which fixed the table cell problem, because it caused a problem with collapsing rows. This won't be the case until I do a checkin today or tomorrow.
Status: NEW → ASSIGNED
Spoke to karnaze during bug triage today. Moving to M11. Not an M10 blocker.
Moving to M13.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago25 years ago
Resolution: --- → FIXED
Troy reinstated Kipp's changes without breaking collapsing rows.
Status: RESOLVED → VERIFIED
Using 11/16 build, verified fixed. Text flows outside the cell.
Keywords: css1
Migrating from {css1} to css1 keyword. The {css1}, {css2}, {css3} and {css-moz} radars should now be considered deprecated in favour of keywords. I am *really* sorry about the spam...
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: