Closed
Bug 6674
Opened 26 years ago
Closed 25 years ago
{css1} overflow rules confused by tables
Categories
(Core :: Layout: Tables, defect, P2)
Tracking
()
VERIFIED
FIXED
M13
People
(Reporter: ian, Assigned: karnaze)
References
()
Details
(Keywords: css1, Whiteboard: [TESTCASE] erin@imaginet.com)
Attachments
(3 files)
For some reason, overflow inside a table is clipped.
For example, the text in the following table:
<table>
<tr>
<td>
<div style="width:80px;">
Truncated? It should not be!
</div>
</td>
</tr>
</table>
...is truncated after the "It". This should not happen, and in fact it doesn't,
if you take the table out.
See the following test case:
http://www.bath.ac.uk/%7Epy8ieh/internet/projects/mozilla/tableoverflow.html
Assignee | ||
Updated•26 years ago
|
Assignee: karnaze → kipp
Assignee | ||
Comment 2•26 years ago
|
||
Kipp, can you take a look. nsTableCellFrame::Reflow makes a call to ReflowChild
on its area frame and it is returning 80px as its desired size.
Reporter | ||
Updated•26 years ago
|
Target Milestone: M15
Reporter | ||
Comment 3•26 years ago
|
||
[Kipp is on sabatical.]
The problem is that the table cell frame painting code is ignoring the css
"overflow" property. In particular, what the cell code does is *always* sets a
clip so that things in the cell can't paint outside.
The fix is to do what the block code does: Test the value of the mOverflow
property and if its value is "NS_STYLE_OVERFLOW_HIDDEN" then and only then set
the clip.
I could make the change, but I'd probably break some nasty navigator
compatibility thing. So I'm reassigning it to karnaze to answer the
compatability question so that he can either nod or frown....I'll even be glad
to make the fix if he wants...
Updated•26 years ago
|
Whiteboard: makingtest erin@imaginet.com
Comment 5•26 years ago
|
||
Comment 6•26 years ago
|
||
Updated•26 years ago
|
Whiteboard: makingtest erin@imaginet.com → [TESTCASE] erin@imaginet.com
Comment 7•26 years ago
|
||
how the browser reads tables and CSS together needs to be fixed
Assignee | ||
Updated•26 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 8•26 years ago
|
||
Kipp, I would appreciate it if you could fix this. Pushing/poping the rendering
context state and setting the clip rect was done to make collapsing row/row
groups work.
Assignee | ||
Updated•26 years ago
|
Assignee: karnaze → kipp
Status: ASSIGNED → NEW
Assignee | ||
Comment 9•26 years ago
|
||
Reassigning to Kipp, based on earlier comments.
Comment 10•26 years ago
|
||
Moving to M10.
Comment 11•26 years ago
|
||
Comment 12•26 years ago
|
||
s/with/without/ in that previous comment. Urk.
Comment 13•26 years ago
|
||
Fixed. The table cell rendering code now honors the css overflow property.
Assignee | ||
Updated•26 years ago
|
Status: RESOLVED → REOPENED
Assignee | ||
Updated•26 years ago
|
Resolution: FIXED → ---
Assignee | ||
Updated•26 years ago
|
Assignee: kipp → karnaze
Status: REOPENED → NEW
Assignee | ||
Comment 14•26 years ago
|
||
I'm going to accept the bug and back out Kipp's changes which fixed the table
cell problem, because it caused a problem with collapsing rows. This won't be
the case until I do a checkin today or tomorrow.
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Comment 15•25 years ago
|
||
Spoke to karnaze during bug triage today. Moving to M11. Not an M10 blocker.
Assignee | ||
Comment 16•25 years ago
|
||
Moving to M13.
Assignee | ||
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 26 years ago → 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 17•25 years ago
|
||
Troy reinstated Kipp's changes without breaking collapsing rows.
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Comment 18•25 years ago
|
||
Using 11/16 build, verified fixed. Text flows outside the cell.
Reporter | ||
Comment 19•25 years ago
|
||
Migrating from {css1} to css1 keyword. The {css1}, {css2}, {css3} and {css-moz}
radars should now be considered deprecated in favour of keywords.
I am *really* sorry about the spam...
You need to log in
before you can comment on or make changes to this bug.
Description
•