This is a place holder bug for me to cleanup our calls to PR_Open and replacing them with mcmullen's better file stream classes. This should help improve stability on the Mac which has a lot of bugs in PR_Open. When I fix the bug, I'll list the files I had to change so QA can verify using code inspection (Par/Suresh?)

accepting.

Files fixed so far: local\src\nsMailboxProtocol.cpp local\src\nsMailboxProtocol.h news\src\nsNntpProtocol.cpp news\src\nsNntpProtocol.h imap\src\nsImapMailFolder.h imap\src\nsImapMailFolder.cpp

fyi: part of this fix caused bug http://bugzilla.mozilla.org/show_bug.cgi?id=7329 which ducarroz has fixed.

I've removed PR_Open use from everywhere but Mime. And it just sprung up in some code in compose as well.

I've fixed a few more spots in nsMsgSend & nsmsgSendPart.cpp but can't seem to get those functions called. I've sent rhp a patch as he's working more closely with this code. I'll check it in if I get a thumbs up from him.

Checked in PR_Open changes for compose\src\nsMsgSend.cpp as well. I just saw another spot in a file called: nsMsgAttachementHandler.cpp which I must have missed before. I'll go look at that right now. After that, it only leaves us with PR_Open calls in mime which I'll save for another bug report.

I've got another patch I'm going to submit to rhp to remove another call to PR_open in nsmsgAttachmentHandler.cpp

Rich checked in my changes for nsMsgAttachementHandler.cpp for me. that leaves just mime which still calls PR_Open and 2 spots in nsMsgSendLater (nsMsgSendLater calls an interface which requires a PRFileSocket....=(). So it will take more time to re-work those. I feel comfortable enough with the progress we've made on this bug for M7 to move it to M8. However, technically we should verify the fixes that we did make for M7. In this bug report I've listed the files I've fixed so far. An easy way to verify is to run a search through all of mailnews directory for the phrase: PR_Open. You should only see 3 occurrences in compose\src\nsMsgSendLater and the rest under the mime directory. No more anywhere else in mailnews... ...the cleanup continues. Moving Target to M8 for the rest of the calls.

Suresh - can you do the verification in M7 as Scott suggests above? Leave this bug open afterwards; just add your comments. Thanks.

Scott, I could see only 2 occurances of PR_Open calls in today's windows debug build. One in compose\src\nsMsgAttachmentHandler.cpp and the other in compose\src\nsMsgSend.cpp. No calls in nsMsgSendLater.cpp.

Sorry nsMsgSend is what I meant not nsSendMsgLater....my bad...and the call in nsMsgAttachementHandler is okay because that code isn't getting executed...I meant to look into removing it as it appears to be obsolete (the file is opened but never written to). So don't worry about that one.

moving to m9

Moving all Mail/News Networking bugs to Mail/News Networking-Mail This may re-open previously Verified bugs due to a Bugzilla bug...if so, I will fix those bugs.

Scott - is there more to do for this bug?

Mime still uses PR_Open everywhere. I've cleaned everything else up. Not a bet stopper though.. M15.

triaging.

I actually fixed this bug a while ago. There are no more occurrences of PR_Open in mailnews. They have all been replaced.

No Mail calls of PR_Open: http://lxr.mozilla.org/seamonkey/search?string=pr_open Verified FIXED using LXR.