Closed
Bug 6776
Opened 25 years ago
Closed 25 years ago
bookmarks.js tries to load container URLs
Categories
(Core Graveyard :: RDF, defect, P3)
Core Graveyard
RDF
Tracking
(Not tracked)
VERIFIED
FIXED
M6
People
(Reporter: mozilla, Assigned: slamm)
Details
The OpenURL() function in mozilla/rdf/resources/bookmarks.js is wrong; clicking
on a container in the sidebar should never try to open up the URL! Here's a
corrected version of what should be done (with the improper JavaScript commented
out.)
function OpenURL(event,node)
{
/*
***** NEVER check against the type! *****
if (node.getAttribute('type') !=
"http://home.netscape.com/NC-rdf#Bookmark") {
return false;
}
*/
/* DO check to see whether the item is a container */
if (node.getAttribute('container') == "true")
{
return false;
}
|
Reporter | |
Updated•25 years ago
|
Target Milestone: M6
|
|
Reporter | |
Comment 1•25 years ago
|
||
I'm setting the target milestone for this to M6 as its a trivial fix. :^)
|
Assignee | |
Updated•25 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•25 years ago
|
||
I will check it in as soon as I get approval.
|
|
Assignee | |
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 3•25 years ago
|
||
Thank you for the fix Robert. I checked it in.
Marking FIXED.
code level fix - i'm marking this verified. if you object, robert, please
reopen...
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•