Closed
Bug 6804
Opened 25 years ago
Closed 25 years ago
ScrollFrameIntoView called with reversed arguments in nsPresShell
Categories
(Core :: Layout, defect, P3)
Core
Layout
Tracking
()
VERIFIED
FIXED
People
(Reporter: alex, Assigned: rickg)
Details
ScrollFrameIntoView looks like this:
NS_IMETHOD ScrollFrameIntoView(nsIFrame *aFrame,
PRInt32 aVOffsetPercent,
PRUint32 aVFlags,
PRInt32 aHOffsetPercent,
PRUint32 aHFlags) const;
The call
rv = ScrollFrameIntoView(frame, NS_PRESSHELL_SCROLL_TOP, 0,
NS_PRESSHELL_SCROLL_LEFT, 0);
is obviously wrong.
Here's a patch. (I posted it on netscape.mozilla.public.(layout,patches) too.
Index: nsPresShell.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/base/src/nsPresShell.cpp,v
retrieving revision 3.133
diff -u -r3.133 nsPresShell.cpp
--- nsPresShell.cpp 1999/05/17 00:21:18 3.133
+++ nsPresShell.cpp 1999/05/20 16:47:03
@@ -1450,7 +1450,7 @@
// Get the primary frame
if (NS_SUCCEEDED(GetPrimaryFrameFor(content, &frame))) {
- rv = ScrollFrameIntoView(frame, NS_PRESSHELL_SCROLL_TOP, 0,
NS_PRESSHELL_SCROLL_LEFT, 0);
+ rv = ScrollFrameIntoView(frame, 0, NS_PRESSHELL_SCROLL_TOP, 0,
NS_PRESSHELL_SCROLL_LEFT);
}
} else {
rv = NS_ERROR_FAILURE;
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
|
||
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
|
|
||
Comment 2•25 years ago
|
||
Fixed in June 1 build.
You need to log in
before you can comment on or make changes to this bug.
Description
•