seen on commercial builds: windows 2001-02-21-06-mtrunk linux 2001-02-21-06-mtrunk mac 2001-02-21-04-trunk -pull down menus Task | Privacy and Security expect to see Personal Security Manager Password Manager Form Manager Cookie Manager?? (i think) but only Personal Security Manager is there.

i don't think this is a smoketest blocker, i think it's a smoketest test rewrite

twalker - can you access those features via the preferences - Edit|Preferences|Advanced|(Cookies,Passwords,Forms)? If the funtionality is there and working and we can access it via prefs but not the Tasks menus this should be critical. If the functionality cannot be accessed at all, it's a blocker.

This probably has to do with my checkin of last night in which I placed those items into a local wallet overlay. I'll investigate.

ah...that's why the prefs advanced list looked short to me...these functions are gone from there also....can't access them through prefs either. timeless...why do you suggest it a rewrite? are these functionalities gone altogether? perhaps moved somewhere else??

No, the functionalities aren't gone, they just got moved to a different module. This is all working on my build so I can't yet explain why it's not working for you. I'm still investigating.

Since this is working in my local tree, I need to pull and build a fresh tree to find out what is going wrong. This will take me two hours and I just started the pull now.

since you can't get to the functionality, it's definitely a blocker. morse - any chance you can take a look at someone else's current tree? we're trying to get ready by noon so we can land dougt's carpool today.

I'm working at home so I can't get to someone else's tree.

morse - did you try clobbering?

Well, if it's not showing up, then it sounds like to me that the overlay isn't getting included in the right place to have it show up. Sounds like a file wasn't checked in.

Repulling and rebuilding is certainly better than cloberring. Build should be ready in half an hour. I did try pulling the bits off of sweetlou. And I was able to reproduce the problem there. But I can't really do any debugging with those bits. I'm starting to suspect that it might be a packaging problem. I'll know the answer to that shortly when I see if my new build has the problem or not.

It could also be a missing file, as Paul suggested. I'll be checking for that as well.

I don't see this problem in my mac debug build; could it be a packaging issue? Is it really a problem on every platform?

While I'm waiting for my win32 build to finish, can anyone else confirm or deny that the problem does not exist on builds from scratch but only exists on prebuild bits (brade already said it's not happening on mac builds). That would narrow down whether or not it is a packaging problem.

I updated from CVS this morning and built (non-clobber) and the menu items are gone.

tested Netscape6-mac-sea.bin bits for the same build id 2001-02-21-04-trunk and the problem does NOT exist.

based on twalker's comments, this sounds like a packaging problem. morse - did you move a bunch of files or create new files that aren't being picked up by the packages-* files?

Yes, I moved a bunch of files and I created new files. But Samuel Seib (above) and dougt (in a phonecall to me) both reported the problem with builds that they made. So that now rules out a packager problem. Looks like brade and twalker are reporting that the problem does not exist on mac. Well, isn't that a switch -- something working on mac but not the other platforms for a change.

that's not what I reported.....the problem DOES exist on mac when using the installer....it Doesn't appear with the sea bits.

Reducing to critical because the problem is missing menu and probably causes by a xul overlay problem. Cc hyatt for his expertise.

My pull/build finally finished. It used to take me exactly two hours to do that (across a DSL line) and this morning it took 2 hours 45 minutes! I am observing the failure with my build. So this is definitely not a packaging problem. Now I can start debugging.

And it's definitely not a problem of forgetting to check in a file. I did an exhaustive check and all changes are acounted for.

OK, here's what the problem is. To meet the super-reviewers request in bug 31967, the code was restructured so that the cookie and wallet chrome files were dumped into comm.jar rather than being in their own separate cookie.jar and wallet.jar. Apparently I never did a clobber-build after making that change. That's why things still kept working for me. Today I did a clobber-build in my old tree (that was working) and it no longer worked. Perhaps I did something wrong in combining all the files into comm.jar. But I spent most of the day today trying to get it to work and was unsuccessful. When I restructured things back to separate jar files, it all worked. If you look at all the other items in the extensions subdirectory, all of them use their own jar files. So I really don't see any reason why cookies and wallet shouldn't do the same. Attaching a patch that uses wallet.jar and cookie.jar instead of comm.jar. This fixes the current bug.

r=dougt (per phonecall that I just had with him)

sr=waterson. ben, talked with morse about this and he had trouble pulling this stuff into the comm.jar package. I understand that you're worried about ``too many top level packages'' (/me is too much of a packaging idiot to know what that means), so if we need to re-open the issue to get this stuff into comm.jar, please do.

cc'ing tpreston who will probably be co-QA-ing this along with tever (this bug spans cookies component, form-manager component, and password-manager component. QA in this case involves making sure that all the UI (task menu, context menu, edit menu, prefs panels) for these features came back -- they got lost as a result of the checkin for bug 31967.

Fix checked in.

*** Bug 69775 has been marked as a duplicate of this bug. ***

reopening...still seeing this bug on commercial builds: linux 2001-02-22-06-mtrunk mac 2001-02-22-04-trunk windows build failed to complete.....will check it soon as a build completes

All I can say is that this is working for me on a debug build that I made from scratch (not an installer build) on windows. I'm building unix right now to see what it's doing.

Don't wallet.jar and cookie.jar need to be added to the packages lists?

That might be the problem. I'll look into that right now.

Just spoke with Samir and apparently there are two ways to get this into the intaller -- the easy way and the hard way. The easy way is to add necessary lines to packages-win, packages-unix, packages-mac, and the three platform-specific versions of browser.jst. The hard way is to create a new jst file for cookies and for wallet and have them isolated from the rest of the installer files, just like chatzilla does. Since cookies and wallet are in the extensions directory, and the whole thrust of bug 31967 was to isolate things in the extensions directory from the core browser, do we need to carry this isolation to the installer level? If so, then we need to take the hard solution. Otherwise we can do the easy one. In any case, I recommend not holding the tree closed for this today. It wasn't working yesterday either and we opened the tree so one more day won't make a difference.

cc-ing samir since I referred to him above.

Attaching the patch for the easy solution. Since wallet and cookie already have other entries in the common installer files, there's no reason to start isolating them now. If this is felt to be important, it can be the subject of a future bug report.

r=sgehani

samir and alecf, hold off your review and super-review for a few minutes. I just build the installer version and tested it. Looks like my patch is missing the .dtd files because the menu items are coming up blank. Will repost a new patch here shortly.

Downgrading to critical to remove from blocker radar.

Oops, latest patch still doesn't show menu items. Back to the drawing board. Because this was a smoketest blocker up until a few minutes ago, I was posting patches in parallel with testing them so that the reviewer could start looking at it. That's why the last two patches were no good. Now that it's been downgraded, I won't post again until I have a working patch.

cc'ing self, since this blocks some of my prefs testing.

OK, let's try once more. Back to the idea of putting everything into comm.jar and en-us.jar. But doing it the right way this time. Attaching a patch for it. This patch has now been tested with a build as well as with the installer.

cc'ing tao cheng for code review.

looks right. r=tao after verification (mozilla & ns) in source tree and installer build on Linux/Windows/Mac. Note that you dont need to (in fact, you can't) test the installer script change part on Mac.

i'd really like to see this become it's own xpi. As wallet is an extension, it should be an option on install and the like, meaning it needs it's own xpi.

r=blake if you fix wallet/jar.mn indentation.

I don't feel I have the expertise to sr this. I would rather defer to Ben Goodger or Alec Flett; however, in their absense, I had both blake and jag look into the most recent patch. Blake has issues he would like to see addressed. Once that is done, then, based on their generally favorable reviews, I think this is OK to go in as a fix to a smoke-test blocker. I'd still like alecf and ben to look at it at their earliest convenience. cc'ing them. [after blake's suggestions] sr=scc (based on review by jag+blake)

Fix checked in (again!). Hopefully I got it right this time.

this is verified fixed on windows and linux....but mac has just two subcatagories listed; Password Manager and Form Manager it is still missing Cooking Manager and Image Manager.

I'm closing this one out since the bug has now been fixed in most platforms and only the mac remains. That's the topic of bug 70232.

verified