Closed
Bug 7288
Opened 26 years ago
Closed 26 years ago
Should folder widget have new interface?
Categories
(Core :: Layout: Form Controls, defect, P3)
Tracking
()
VERIFIED
INVALID
M8
People
(Reporter: michael.j.lowe, Assigned: rods)
Details
Rod,
At present the folder picker uses the nsIFileWidget interface. To me, it seems
like the file picker and the folder picker are two seperate symantic entities
and that it would be better to reduce the clutter in nsIFileWidget and create a
new interface for the folder picker, nsIFolderWidget as well as a new class
nsFolderWidget.
Michael
Comment 1•26 years ago
|
||
adding sdagley to cc list.
rod, didn't Steve already have different and uncluttered interfaces he wanted to
use, but we decided anyway on extending nsIFileWidget? Maybe now is a good time
to go back to what Steve originally proposed.
Assignee | ||
Comment 2•26 years ago
|
||
We can do that, but if I remember it correctly his interface was for file
picking and folder picking and that there was already an interface that did file
picking. It didn't have anything to do with seprarting the folder picker from
the file picker.
Comment 3•26 years ago
|
||
I would nix this request for 2 reasons:
1) The folder choosing functionality adds a single method to the file widget.
This has gotta be less clutter than adding a whole new set of files.
2) While you might think file and folder selection are seperate entities they are
virtually identical at the OS call level, at least for Mac and Windows.
Part of the problem is that the file widget is really more of a service than a
widget but it remains named a widget for historical reasons.
Reporter | ||
Comment 4•26 years ago
|
||
Sure, but the file picker and folder picker are really seperate services, which
share nothing in common. Having them in the same interface seems like a
mistake to me. The whole point of having classes is to provide a higher level
abstraction than the OS level, and so OS considerations are mute. It is better
to think about higher level clients might need to use these interfaces, and the
intersection of file and folder picker functionality is zip. Isn't it
conceptually cleaner to break them out?
Updated•26 years ago
|
Target Milestone: M8
Comment 5•26 years ago
|
||
M8. This really isn't a bug, hopefully it
should be marked as such by M8 timeframe.
Moving all Widget Set bugs, past and present, to new HTML Form Controls
component per request from karnaze. Widget Set component will be retired
shortly.
Assignee | ||
Updated•26 years ago
|
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → INVALID
Assignee | ||
Comment 7•26 years ago
|
||
The discussion has been moed to the newsgroup for a wider audience, and I am
closing this bug.
You need to log in
before you can comment on or make changes to this bug.
Description
•