Closed
Bug 7404
Opened 26 years ago
Closed 25 years ago
left and right arrow keys don't scroll
Categories
(Core :: DOM: UI Events & Focus Handling, defect, P3)
Core
DOM: UI Events & Focus Handling
Tracking
()
VERIFIED
FIXED
M16
People
(Reporter: cpratt, Assigned: joki)
References
()
Details
(Keywords: testcase, Whiteboard: [PATCH])
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/plain
|
Details |
build id: 1999052619
platform: windwos nt
to reproduce, go to the above url or to any other page that's too wide for the
default apprunner window to display without drawing scrollbars. when the page
has loaded, use the up and down arrow keys to scroll up and down, and then try
the left and right arrow keys to scroll from left to right. result: you can't.
expected result: you can.
Updated•26 years ago
|
Whiteboard: [MAKINGTEST] Antti.Nayha@oulu.fi
Updated•26 years ago
|
Summary: left and right arrow keys don't scroll → [4.xP] left and right arrow keys don't scroll
Whiteboard: [MAKINGTEST] Antti.Nayha@oulu.fi → [TESTCASE] scrolling with left and right arrow keys needs to be implemented
Comment 2•26 years ago
|
||
Verified the bug on the following builds:
- 1999071417 Viewer on Windows NT 4.0 SP4
- 1999071417 Apprunner on Windows NT 4.0 SP4
- M7 Apprunner on Windows NT 4.0 SP4
Verified the URL as a valid test case - actually, the bug can be reproduced on
virtually any page (including a Bugzilla page) simply by narrowing the browser
window enough.
Also added the [4.xP] identifier.
Comment 3•25 years ago
|
||
Is there a Target Milestone for this bug? It's a reasonably important feature
(and I wouldn't think it's too hard to implement, considering vertical arrows
already work).
Updated•25 years ago
|
OS: Windows NT → All
Comment 6•25 years ago
|
||
Marking all as it doesn't work on Linux or NT.
Assignee | ||
Updated•25 years ago
|
Target Milestone: M14
Comment 7•25 years ago
|
||
Bulk moving [testcase] code to new testcase keyword. Sorry for the spam!
Keywords: testcase
Updated•25 years ago
|
Summary: [4.xP] left and right arrow keys don't scroll → left and right arrow keys don't scroll
Assignee | ||
Comment 9•25 years ago
|
||
I'm torn on whether this should be PDT+ or not. But I don't have time to do it
tonight. I'll move it to M15 and people can argue over it there if they choose.
Target Milestone: M14 → M15
Comment 10•25 years ago
|
||
Comment 11•25 years ago
|
||
*** Bug 30053 has been marked as a duplicate of this bug. ***
Comment 12•25 years ago
|
||
*** Bug 18380 has been marked as a duplicate of this bug. ***
Comment 13•25 years ago
|
||
jan, i'll take this one off your hands. lemme know if you want it back. ;-)
QA Contact: janc → sairuh
Comment 14•25 years ago
|
||
*** Bug 32698 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 15•25 years ago
|
||
Mass-moving bugs out of M15 that I won't get to. Will refit individual
milestones after moving them.
Target Milestone: M15 → M16
Comment 16•25 years ago
|
||
Nominating for beta2. This is an important feature for wide pages, and works in
4.x. I wouldn't think it should be too hard to fix...
Keywords: beta2
Comment 17•25 years ago
|
||
The problems happens on Sun's platform, too, on pre-beta as well as a local
cvs-child
build(2000030708). This is serious regression from 4.7, so set the priority to
critical.
Severity: normal → critical
Keywords: beta2
Updated•25 years ago
|
Hardware: PC → All
Comment 18•25 years ago
|
||
*** Bug 38250 has been marked as a duplicate of this bug. ***
Comment 19•25 years ago
|
||
*** Bug 38558 has been marked as a duplicate of this bug. ***
Comment 20•25 years ago
|
||
i un-dup'ed 35558 again for now, but it is the same problem.
The submitter has attached a patch for this problem, however.
Someone should take a look.
Comment 21•25 years ago
|
||
The patch I posted to fix bug 38558 is almost same as patch from Matt Bissiri
Horizontal scrolling is working for me now, can someone review this patches ?
Comment 22•25 years ago
|
||
Adding myself to CC list
Comment 23•25 years ago
|
||
*** Bug 38703 has been marked as a duplicate of this bug. ***
Comment 24•25 years ago
|
||
*** Bug 38703 has been marked as a duplicate of this bug. ***
Comment 25•25 years ago
|
||
Comment 26•25 years ago
|
||
I updated the patch from Matt Bissiri (Feb 18) to use
|nsCAutoString(...).EqualsWithConversion(...)|, and built
and tested on linux. Works for me :-).
Whiteboard: [TESTCASE] scrolling with left and right arrow keys needs to be implemented → [PATCH]
Assignee | ||
Comment 27•25 years ago
|
||
Okay, fix checked in. Thanks for the patches.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Comment 28•25 years ago
|
||
*** Bug 38558 has been marked as a duplicate of this bug. ***
Comment 29•25 years ago
|
||
Is anybody else seeing that one can horizontally scroll to the left with the
keys and then cycle around? I guess a new bug should be opened...
Comment 30•25 years ago
|
||
david, which platform? i don't get the cycling around on linux (browser
window)...
Comment 31•25 years ago
|
||
Linux. I was using my debug tree, which has some other changes in it, although
I don't think they would affect this. Are you lookin at a page that scrolls
horizontally. (You may need to go all the way to the right first, because it
may need to be at an uneven offset -- I forget.)
Comment 32•25 years ago
|
||
i was looking at a page whose content is wider than the browser's window. here
are the steps i took (lemme know if you ran into the problem a different way):
1. a bugzilla report page such as this one.
2. i make the browser window small enough so that the horizontal scrollbar
appears.
3. hit the right arrow key so that it scrolls all the way to the right.
4. hit the left arrow key so that it scrolls all the way to the left.
5. keep hitting the left arrow key. result: it doesn't cycle.
admittedly, i'm using an optimized [commercial] build from this am
[2000.05.16.08]...
Comment 33•25 years ago
|
||
dbaron : I don't see this 'wrap-around' with today's verification builds
mac/win32/linux, or with a debug linux build from this morning.
However, I note that Matt Bissiri had this in the patch " // XXX Should
we be paranoid and check for out of bounds x here, // even though
ScrollingView::ScrollTo clamps x and y values?". Matt -- comments?
(On an related note, you need to set focus to the content area before you
can scroll, but that's a separate bug (the number of which escapes me
at the moment)).
Comment 34•25 years ago
|
||
I can't see it anymore either...
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Comment 35•25 years ago
|
||
woo! verif using 2000.05.18.08 on winNT, mac and linux.
Updated•6 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•