Closed Bug 787612 Opened 12 years ago Closed 5 years ago

Port |Bug 596234 - Body of RSS feeds won't print or print preview| to SeaMonkey

Categories

(SeaMonkey :: MailNews: Message Display, defect, P2)

Product:
SeaMonkey
Component:
MailNews: Message Display
Type:
defect

Tracking

(seamonkey2.49esr wontfix, seamonkey2.63 wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.68
Tracking Flags:
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.63 --- wontfix
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed

People

(Reporter: philip.chee, Assigned: iannbugzilla)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: SM2.53.1)

Attachments

(1 file, 2 obsolete files)

RSS Feeds Printing fix v1.2
(deleted), patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review
From Bug 596234 comment 0: > When printing RSS "messages" from craigslist in "News and Blogs" section of > Thunderbird, only the message header and footer print, the body is blank. The > body and images ARE visible on the screen. Email messages (as opposed to News > and Blogs messages) with HTML print properly. > > Reproducible: Always > > Steps to Reproduce: > 1. Subscribe to a craigslist RSS feed in "News and Blogs" such as > <http://sfbay.craigslist.org/search/boa?query=catalina > +27&catAbbreviation=boa&minAsk=min&maxAsk=max&format=rss> > 2.When you get a new message for this feed, click on the message > 3.Choose Print or Print Preview. You will notice that there is not message body > printed, only the header and footer. > Actual Results: > Message printed with header and footer visible, no body is visible. > > Expected Results: > I expected the whole message to print, header, body, and footer (WYSIWYG). > Tbird V2 worked properly. > > The reason this is a "Major" bug is, because of the fleeting nature of news > feeds, I like to archive important ones by printing to a PDF file. If I can't > print from Tbird, I'll have to use a different RSS reader.
Blocks: TB2SM
Should port followup bug as well: Bug 793838 - Feed body AppMenu items are not working anymore
Depends on: 793838

Port the following:
Bug 596234 - Body of RSS feeds won't print or print preview
Bug 793838 - Feed body AppMenu items are not working anymore
Bug 866498 - Radio group for Main Menu Bar->View->Feed Message Body As not working correctly
Bug 1025548 - Preliminary perf/code org tweaks for Bug 257037 - Part 4

Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Component: MailNews: General → MailNews: Message Display
Attached patch RSS Feeds Printing fix (obsolete) (deleted) — — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: Cannot print / preview RSS feed items
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Attachment #9088674 - Flags: review?(frgrahl)
Attachment #9088674 - Flags: approval-comm-release?
Attachment #9088674 - Flags: approval-comm-esr60?
Attached patch RSS Feeds Printing fix v1.1 (obsolete) (deleted) — — Splinter Review

Replaced some single quotes for double quotes in the code being changed.

Attachment #9088674 - Attachment is obsolete: true
Attachment #9088674 - Flags: review?(frgrahl)
Attachment #9088674 - Flags: approval-comm-release?
Attachment #9088674 - Flags: approval-comm-esr60?
Attachment #9089563 - Flags: review?(frgrahl)
Attachment #9089563 - Flags: approval-comm-release?
Attachment #9089563 - Flags: approval-comm-esr60?
Attached patch RSS Feeds Printing fix v1.2 (deleted) — — Splinter Review

Now includes ports of part of:

  • Bug 1151497 - Web site from RSS feed not rendered correctly (due to noscript tags) - tab part

This fixes the issue with message pane only ever showing the summary rather than following what was selected under View > Feed Body As

Print only ever shows Summary

Attachment #9089563 - Attachment is obsolete: true
Attachment #9089563 - Flags: review?(frgrahl)
Attachment #9089563 - Flags: approval-comm-release?
Attachment #9089563 - Flags: approval-comm-esr60?
Attachment #9092861 - Flags: review?(frgrahl)
Attachment #9092861 - Flags: approval-comm-release?
Attachment #9092861 - Flags: approval-comm-esr60?
Comment on attachment 9092861 [details] [diff] [review] RSS Feeds Printing fix v1.2 lgtm. r/a+ A bit confusing because the message is always displayed as a web page and the menu options only affect the preview in the 3pane but it is exactly as TB handles it.
Attachment #9092861 - Flags: review?(frgrahl)
Attachment #9092861 - Flags: review+
Attachment #9092861 - Flags: approval-comm-release?
Attachment #9092861 - Flags: approval-comm-release+
Attachment #9092861 - Flags: approval-comm-esr60?
Attachment #9092861 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/c2a54bcf5083
Port Bug 596234 "Body of RSS feeds won't print or print preview| to SeaMonkey". r=frg

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Blocks: 1581508
Regressions: 1589873
Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: