Closed
Bug 82625
Opened 24 years ago
Closed 23 years ago
we should support DOM treeWalker
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
VERIFIED
FIXED
People
(Reporter: sicking, Assigned: sicking)
Details
Attachments
(8 files)
(deleted),
application/x-zip-compressed
|
Details | |
(deleted),
text/html
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
fabian
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
fabian
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
It would be nice to support the DOM treeWalker interface. Full implementation
coming up...
Assignee | ||
Comment 1•24 years ago
|
||
Assignee | ||
Comment 2•24 years ago
|
||
Assignee | ||
Comment 3•24 years ago
|
||
The diff+new files in the diff implements the nsIDOMDocumentTraversal and
nsIDOMTreeWalker interfaces. All that's needed for full DOM Traversal support
is NodeIterator.
I wasn't sure if the nsIDOMDocumentTraversal interface should be added in
domstubs.idl, nsIDOMClassInfo.h and nsDOMClassInfo.cpp files, but the other
nsIDOMDocument* interfaces didn't seem to be so I left it out.
Status: NEW → ASSIGNED
Keywords: review
Comment 4•24 years ago
|
||
FWIW, I tested this on linux. The patch applies cleanly, it builds fine, and it
works fine (from the little testing I did). Even nodeFilters work :)
Keywords: patch
Assignee | ||
Comment 5•24 years ago
|
||
I just remembered that I shouldn't use 0 to return null. Changed to nsnull
everywhere in my tree
Comment 6•24 years ago
|
||
Jonas, this rocks!
I just checked in your interface files into mozilla/dom/public/idl/traversal, I
have some comments (stylistic, mostly) about the other files and changes, let's
chat about this on #mozilla.
Assignee | ||
Comment 7•24 years ago
|
||
Assignee | ||
Comment 8•24 years ago
|
||
Assignee | ||
Comment 9•24 years ago
|
||
Assignee | ||
Comment 10•24 years ago
|
||
another batch up for review. Basically I've made some idl changes jst wanted
and fixed a bunsh of stylistic stuff in nsTreeWalker.cpp
Comment 11•24 years ago
|
||
One additional change that's needed to get this to work in nightly builds is to
add dom_traversal.xpt to the package files that the installer uses.
Assignee | ||
Comment 12•24 years ago
|
||
Have added the xpinstaller stuff in my tree... Though I couldn't find and
basebrowser-mac for embedding though?
Assignee | ||
Comment 13•23 years ago
|
||
jst: I've (almost) redone the implementation using nsIContent rather then
nsIDOMNode. However I've ran into a pretty big problem: document nodes don't
implement nsIContent :(.
So my plan is to use nsIDOMNodes/GetChildNodes but QI to nsIContent/nsIDocument
when I need to get IndexOf. Sounds like a plan?
Assignee | ||
Comment 14•23 years ago
|
||
this finally works in my tree. I'll just make it blazingly fast then i'll
attach a patch...
Assignee | ||
Comment 15•23 years ago
|
||
Assignee | ||
Comment 16•23 years ago
|
||
Comment 17•23 years ago
|
||
In addition to the attached patch you also need to add dom_traversal.xpt to the
packaging files:
embedding/config/basebrowser-unix
embedding/config/basebrowser-win
xpinstall/packager/packages-win
xpinstall/packager/packages-mac
xpinstall/packager/packages-unix
xpinstall/packager/packages-static-unix
Comment 18•23 years ago
|
||
Comment on attachment 48389 [details] [diff] [review]
addresses comments from jst
sr=jst
Attachment #48389 -
Flags: superreview+
Comment 19•23 years ago
|
||
Comment on attachment 48389 [details] [diff] [review]
addresses comments from jst
r=fabian (i'll get you on the next one for the style nits)
Attachment #48389 -
Flags: review+
Assignee | ||
Comment 20•23 years ago
|
||
Comment 21•23 years ago
|
||
Comment on attachment 48508 [details] [diff] [review]
xpinstall and embedding stuff
grepped the source and couldn't find any other places.. kewl
r=fabian
Attachment #48508 -
Flags: review+
Comment 22•23 years ago
|
||
Comment on attachment 48508 [details] [diff] [review]
xpinstall and embedding stuff
sr=jst
Attachment #48508 -
Flags: superreview+
Assignee | ||
Comment 23•23 years ago
|
||
ugh, forgot that i need a macbuddy.. hopefully I can convince peterv tomorrow
Assignee | ||
Comment 24•23 years ago
|
||
patches landed...
Thanks everybody that helped to test/review/land/comment on this!
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Component: DOM: Traversal-Range → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•