Closed
Bug 8292
Opened 25 years ago
Closed 25 years ago
[PP] Toolbar buttons not underlined on Mac
Categories
(Core :: Layout, defect, P3)
Tracking
()
VERIFIED
FIXED
M9
People
(Reporter: mikepinkerton, Assigned: mikepinkerton)
Details
(Whiteboard: [19990809] no access to Mac until 19990810)
The toolbar buttons on win32 underline their text on mouseOver. On mac, they
don't. Was this on purpose?
Updated•25 years ago
|
Assignee: radha → german
Comment 1•25 years ago
|
||
UI issues. reassigning to german
I noticed it too. This was found on any titled button on the mac, it does not
show when the CSS style 'text-decoration' is set to "underline". Reassign to
perter's team, do not know whether this bug is raptor/style related or widget
related.
Comment 3•25 years ago
|
||
8900, a bug on the underline button in the editor toolbar not looking underlined
on linux, may be the same issue (but I filed it separately in case it's
different).
Updated•25 years ago
|
Assignee: trudelle → evaughan
Comment 4•25 years ago
|
||
assigning to evaughan as p3 for M9
Updated•25 years ago
|
Assignee: evaughan → pinkerton
Comment 5•25 years ago
|
||
This looks like a mac platform parity bug.
Assignee | ||
Updated•25 years ago
|
Assignee: pinkerton → beard
Component: XP Toolkit/Widgets → Layout
Assignee | ||
Comment 6•25 years ago
|
||
The style is set correctly (the nsStyleFont->mFont->decorations has the underline
flag set correctly). It appears that the routines that draw the text in
nsUnicodeRenderingToolkit.cpp never check the decorations field before calling
::DrawText().
I don't know that code at all, so I don't want to go digging around and make
mistakes. beard touched it last, so it goes to him. Tag! ;)
Assignee | ||
Updated•25 years ago
|
Assignee: beard → pinkerton
Assignee | ||
Comment 7•25 years ago
|
||
I stumbled upon nsRenderingContextMac::SetPortTextState and found that it was the
culprit. I have a fix, taking bug back.
Assignee | ||
Updated•25 years ago
|
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•25 years ago
|
||
fixed. added check for the right flag in nsFontMetricsMac.cpp. You should see
this on the daily builds starting on Aug9th (Monday).
Updated•25 years ago
|
Whiteboard: [19990809] no access to Mac until 19990810
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Comment 9•25 years ago
|
||
using 1999082016 build on mac -- it now gets the underbar on mouseover
You need to log in
before you can comment on or make changes to this bug.
Description
•