Closed Bug 8292 Opened 25 years ago Closed 25 years ago

[PP] Toolbar buttons not underlined on Mac

Categories

(Core :: Layout, defect, P3)

PowerPC
Mac System 8.5
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: mikepinkerton, Assigned: mikepinkerton)

Details

(Whiteboard: [19990809] no access to Mac until 19990810)

The toolbar buttons on win32 underline their text on mouseOver. On mac, they don't. Was this on purpose?
Assignee: don → radha
Target Milestone: M9
Assignee: radha → german
UI issues. reassigning to german
Assignee: german → trudelle
Component: XPApps → XP Toolkit/Widgets
I noticed it too. This was found on any titled button on the mac, it does not show when the CSS style 'text-decoration' is set to "underline". Reassign to perter's team, do not know whether this bug is raptor/style related or widget related.
8900, a bug on the underline button in the editor toolbar not looking underlined on linux, may be the same issue (but I filed it separately in case it's different).
Assignee: trudelle → evaughan
assigning to evaughan as p3 for M9
Assignee: evaughan → pinkerton
This looks like a mac platform parity bug.
Assignee: pinkerton → beard
Component: XP Toolkit/Widgets → Layout
The style is set correctly (the nsStyleFont->mFont->decorations has the underline flag set correctly). It appears that the routines that draw the text in nsUnicodeRenderingToolkit.cpp never check the decorations field before calling ::DrawText(). I don't know that code at all, so I don't want to go digging around and make mistakes. beard touched it last, so it goes to him. Tag! ;)
Assignee: beard → pinkerton
I stumbled upon nsRenderingContextMac::SetPortTextState and found that it was the culprit. I have a fix, taking bug back.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
fixed. added check for the right flag in nsFontMetricsMac.cpp. You should see this on the daily builds starting on Aug9th (Monday).
Whiteboard: [19990809] no access to Mac until 19990810
Status: RESOLVED → VERIFIED
using 1999082016 build on mac -- it now gets the underbar on mouseover
You need to log in before you can comment on or make changes to this bug.