Closed
Bug 86296
Opened 23 years ago
Closed 23 years ago
Spellcheck on send: window shouldn't pop-up when no typos found
Categories
(MailNews Core :: Composition, enhancement)
MailNews Core
Composition
Tracking
(Not tracked)
VERIFIED
DUPLICATE
of bug 132697
People
(Reporter: mozilla-bugs, Assigned: vparthas)
References
Details
Attachments
(1 file)
(deleted),
patch
|
cmanske
:
review+
|
Details | Diff | Splinter Review |
When I have the "spellcheck on send" option enabled, the spellchecker window
will pop-up even if it has nothing to say (i.e. it didn't find any typos).
Reproducible: always
Steps to reproduce:
1) Enable "Spellcheck on send" option.
2) Compose an e-mail with no typos.
3) Press "Send"
Expected result: the message is sent, no spellchecker window appears.
Actual result: spellchecker window appears with no typo listed.
Comment 2•23 years ago
|
||
I think this bug should be resolved as invalid or wontfix. The spellchecker
needs to popup in case the user wants to change the language to be used for
spellchecking.
OS: Linux → All
Hardware: PC → All
Reporter | ||
Comment 3•23 years ago
|
||
Are you saying - you are afraid of a situation where the message has correct
spelling in the default language, but wrong spelling in the lanfguage it was
meant to be in? This scenario does not seem realistic to me and I do not think
that this extremely unlikely scenario is sufficient reason to cause people to go
through the spell-check window when they have spelled everything correctly.
Comment 5•23 years ago
|
||
Language should be specified somewhere in Preferences, not during the operation.
Anyone who actually *uses* the spell checker will go bonkers over time, having
to close a window when their spelling is just fine.
Comment 6•23 years ago
|
||
Ok, this patch adds a pref "mail.dontHarassPerfectSpellers". It appears to
work on my machine, whatever that means. I don't thin that it will have any
long term effects on anyones mental health, but it sure makes life easier.
I did not add this pref to the Prefs dialog, but if this is the way to fix this
bug, it is probably worth doing.
Comment 7•23 years ago
|
||
cmanske should review the patch.
Comment 8•23 years ago
|
||
Comment on attachment 70767 [details] [diff] [review]
A patch
Good idea!
r=cmanske, but only if
you call
onClose()
instead of
window.close();
This is needed to close
down the spell checker properly
Attachment #70767 -
Flags: review+
Comment 9•23 years ago
|
||
Yes, but --
onClose or onCancel do not work when called from Startup. I figured that
what I was doing was wrong, or at least leaky, but there should be some way of
cleanly deciding to abandon a dialog at startup.
Comment 10•23 years ago
|
||
Of course!
Just call:
spellChecker.UninitSpellChecker();
window.close();
Comment 11•23 years ago
|
||
I think that that is what I do, isn't it.
Comment 12•23 years ago
|
||
doh! yes. :)
Comment 13•23 years ago
|
||
Hi,
What's the process for getting a target milestone for this guy?
Thanks
Comment 14•23 years ago
|
||
This bug is subsumed by the fix to 132697. Thanks cmanske!
*** This bug has been marked as a duplicate of 132697 ***
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
verified dup (can't wait to see that patch _land_)
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•